[
https://issues.apache.org/jira/browse/HDFS-8450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14574411#comment-14574411
]
Kai Zheng commented on HDFS-8450:
---------------------------------
Thanks Rakesh again for the update. More comments, would you help check one
more time? Thanks!
1. {{ErasureCodingZoneManager}} mostly uses {{iip}} instead of {{src}} except
{{createErasureCodingZone}}, so better to refactor it? Thus
{{FSDirErasureCodingOp#createErasureCodingZone}} can also be simplified, using
the utility {{getINodesInPath}}.
2. I don't quite like passing {{fsd}} and {{ecManager}}, instead just passing
{{fsn}} is good enough. Please check other places.
{code}
+ private static ErasureCodingZone getErasureCodingZone(final FSDirectory fsd,
+ final INodesInPath iip, final ErasureCodingZoneManager ecManager)
+ throws IOException {
{code}
3. How about changing {{fsn.getECSchemaManager}} this time together?
Thanks again!
> Erasure Coding: Consolidate erasure coding zone related implementation into a
> single class
> ------------------------------------------------------------------------------------------
>
> Key: HDFS-8450
> URL: https://issues.apache.org/jira/browse/HDFS-8450
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Rakesh R
> Assignee: Rakesh R
> Attachments: HDFS-8450-FYI.patch, HDFS-8450-HDFS-7285-00.patch,
> HDFS-8450-HDFS-7285-01.patch, HDFS-8450-HDFS-7285-02.patch,
> HDFS-8450-HDFS-7285-03.patch, HDFS-8450-HDFS-7285-04.patch,
> HDFS-8450-HDFS-7285-05.patch, HDFS-8450-HDFS-7285-07.patch,
> HDFS-8450-HDFS-7285-08.patch
>
>
> The idea is to follow the same pattern suggested by HDFS-7416. It is good to
> consolidate all the erasure coding zone related implementations of
> {{FSNamesystem}}. Here, proposing {{FSDirErasureCodingZoneOp}} class to have
> functions to perform related erasure coding zone operations.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
