[ 
https://issues.apache.org/jira/browse/HDFS-8551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14577543#comment-14577543
 ] 

Xiaoyu Yao commented on HDFS-8551:
----------------------------------

[~brahmareddy], can you fix the checkstyle issue? Otherwise, looks good to me.
./hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java:268:
 Line is longer than 80 characters (found 83).

> Fix hdfs datanode CLI usage message
> -----------------------------------
>
>                 Key: HDFS-8551
>                 URL: https://issues.apache.org/jira/browse/HDFS-8551
>             Project: Hadoop HDFS
>          Issue Type: Bug
>    Affects Versions: 2.6.0
>            Reporter: Xiaoyu Yao
>            Assignee: Brahma Reddy Battula
>         Attachments: HDFS-8551.patch
>
>
> There are two issues with current "hdfs datanode" usage message below.
> {code}
> Usage: java DataNode [-regular | -rollback]
>     -regular                 : Normal DataNode startup (default).
>     -rollback                : Rollback a standard or rolling upgrade.
>   Refer to HDFS documentation for the difference between standard
>   and rolling upgrades.
> {code}
> 1. "java DataNode" should be "hdfs datanode"
> 2. "rollingupgrace" option is missing but it is document correctly in the 
> [link|http://hadoop.apache.org/docs/r2.7.0/hadoop-project-dist/hadoop-hdfs/HDFSCommands.html#datanode].
> {code}
> Usage: hdfs datanode [-regular | -rollback | -rollingupgrace rollback]
> COMMAND_OPTION        Description
> -regular      Normal datanode startup (default).
> -rollback     Rollback the datanode to the previous version. This should be 
> used after stopping the datanode and distributing the old hadoop version.
> -rollingupgrade rollback      Rollback a rolling upgrade operation.
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to