[ 
https://issues.apache.org/jira/browse/HDFS-8450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14578781#comment-14578781
 ] 

Rakesh R commented on HDFS-8450:
--------------------------------

Thanks again [~vinayrpet] for reviews. Could you please give few details about 
below comments:
bq. NameNodeAdapter.java, acquire fsn#readLock() within getFileInfo().
I'm referring to this class 
[NameNodeAdapter.java|https://github.com/apache/hadoop/blob/HDFS-7285/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/NameNodeAdapter.java#L71].
 I couldn't see any erasure coding related function calls in this class, it 
would be helpful if you give some details about the necessity of 
{{sn#readLock()}} in {{#getFileInfo}} function. Thanks!

> Erasure Coding: Consolidate erasure coding zone related implementation into a 
> single class
> ------------------------------------------------------------------------------------------
>
>                 Key: HDFS-8450
>                 URL: https://issues.apache.org/jira/browse/HDFS-8450
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>            Reporter: Rakesh R
>            Assignee: Rakesh R
>         Attachments: HDFS-8450-FYI.patch, HDFS-8450-HDFS-7285-00.patch, 
> HDFS-8450-HDFS-7285-01.patch, HDFS-8450-HDFS-7285-02.patch, 
> HDFS-8450-HDFS-7285-03.patch, HDFS-8450-HDFS-7285-04.patch, 
> HDFS-8450-HDFS-7285-05.patch, HDFS-8450-HDFS-7285-07.patch, 
> HDFS-8450-HDFS-7285-08.patch, HDFS-8450-HDFS-7285-09.patch, 
> HDFS-8450-HDFS-7285-10.patch, HDFS-8450-HDFS-7285-11.patch
>
>
> The idea is to follow the same pattern suggested by HDFS-7416. It is good  to 
> consolidate all the erasure coding zone related implementations of 
> {{FSNamesystem}}. Here, proposing {{FSDirErasureCodingZoneOp}} class to have 
> functions to perform related erasure coding zone operations.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to