[ 
https://issues.apache.org/jira/browse/HDFS-8582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14586440#comment-14586440
 ] 

Colin Patrick McCabe commented on HDFS-8582:
--------------------------------------------

I think it's a good idea to have a list of reconfigurable properties 
available... the new listAllowed command is nice.  Rather than calling it 
"listAllowed" (which suggests a permission issue), why not just call it 
"properties"?  The first part of the command is {{dfs dfsadmin -reconfig 
<datanode|...> <host:ipc_port>}} so it will be obvious that the properties 
pertain to reconfiguration.

{{GetReconfigurationAllowedPropertiesResponse}}: should be 
{{GetReconfigurablePropertiesResponse}}.  Similar with Request, etc. etc.

bq. DataNode's Configuration object is actually HdfsConfiguration, which sets a 
few default values for certain keys. But the reconfiguration framework used 
here just set the missing keys with empty / None values. Thus there are 
differences.

When I type {{dfs dfsadmin -reconfig <datanode|...> <host:ipc_port>}} the 
reconfiguration framework knows that I am reconfiguring a datanode.  So it 
should use the correct defaults for the datanode.  This seems like a much 
cleaner solution than hacking around this by suppressing certain valid messages 
at the client.

> Reduce failure messages when running datanode reconfiguration
> -------------------------------------------------------------
>
>                 Key: HDFS-8582
>                 URL: https://issues.apache.org/jira/browse/HDFS-8582
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: HDFS
>    Affects Versions: 2.7.0
>            Reporter: Lei (Eddy) Xu
>            Assignee: Lei (Eddy) Xu
>            Priority: Minor
>         Attachments: HDFS-8582.000.patch, HDFS-8582.001.patch, 
> HDFS-8582.002.patch
>
>
> When running a DN reconfig to hotswap some drives, it spits out this output:
> {noformat}
> $ hdfs dfsadmin -reconfig datanode localhost:9023 status
> 15/06/09 14:58:10 WARN util.NativeCodeLoader: Unable to load native-hadoop 
> library for your platform... using builtin-java classes where applicable
> Reconfiguring status for DataNode[localhost:9023]: started at Tue Jun 09 
> 14:57:37 PDT 2015 and finished at Tue Jun 09 14:57:56 PDT 2015.
> FAILED: Change property 
> rpc.engine.org.apache.hadoop.hdfs.protocolPB.ClientDatanodeProtocolPB
>         From: "org.apache.hadoop.ipc.ProtobufRpcEngine"
>         To: ""
>         Error: Property 
> rpc.engine.org.apache.hadoop.hdfs.protocolPB.ClientDatanodeProtocolPB is not 
> reconfigurable.
> FAILED: Change property mapreduce.client.genericoptionsparser.used
>         From: "true"
>         To: ""
>         Error: Property mapreduce.client.genericoptionsparser.used is not 
> reconfigurable.
> FAILED: Change property rpc.engine.org.apache.hadoop.ipc.ProtocolMetaInfoPB
>         From: "org.apache.hadoop.ipc.ProtobufRpcEngine"
>         To: ""
>         Error: Property rpc.engine.org.apache.hadoop.ipc.ProtocolMetaInfoPB 
> is not reconfigurable.
> SUCCESS: Change property dfs.datanode.data.dir
>         From: "file:///data/1/user/dfs"
>         To: "file:///data/1/user/dfs,file:///data/2/user/dfs"
> FAILED: Change property dfs.datanode.startup
>         From: "REGULAR"
>         To: ""
>         Error: Property dfs.datanode.startup is not reconfigurable.
> FAILED: Change property 
> rpc.engine.org.apache.hadoop.hdfs.protocolPB.InterDatanodeProtocolPB
>         From: "org.apache.hadoop.ipc.ProtobufRpcEngine"
>         To: ""
>         Error: Property 
> rpc.engine.org.apache.hadoop.hdfs.protocolPB.InterDatanodeProtocolPB is not 
> reconfigurable.
> FAILED: Change property 
> rpc.engine.org.apache.hadoop.hdfs.protocolPB.DatanodeProtocolPB
>         From: "org.apache.hadoop.ipc.ProtobufRpcEngine"
>         To: ""
>         Error: Property 
> rpc.engine.org.apache.hadoop.hdfs.protocolPB.DatanodeProtocolPB is not 
> reconfigurable.
> FAILED: Change property 
> rpc.engine.org.apache.hadoop.tracing.TraceAdminProtocolPB
>         From: "org.apache.hadoop.ipc.ProtobufRpcEngine"
>         To: ""
>         Error: Property 
> rpc.engine.org.apache.hadoop.tracing.TraceAdminProtocolPB is not 
> reconfigurable.
> {noformat}
> These failed messages are spurious and should not be shown.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to