[ 
https://issues.apache.org/jira/browse/HDFS-8462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14591088#comment-14591088
 ] 

Akira AJISAKA commented on HDFS-8462:
-------------------------------------

Thanks [~jagadesh.kiran] for updating the patch. Mostly looks good to me.
I found that if the provided xattr.name is not found in the specified path, 
WebImageViewer returns 500 (Internal Server Error). In contrast, WebHDFS 
returns 403 (Forbidden) in the same condition. The reason is, if 
{{IOException}} occurs, {{FSImageHandler#exceptionCaught}} sets 500, and 
{{o.a.h.hdfs.web.ExceptionHandler#toResponse}} sets 403.
Would you fix the return code to 403 in {{FSImageHandler}} when IOException 
happens? We can safely fix it in this jira because IOException should not 
happen in the other operations (GETFILESTATUS, LISTSTATUS, GETACLSTATUS).

> Implement GETXATTRS and LISTXATTRS operation for WebImageViewer
> ---------------------------------------------------------------
>
>                 Key: HDFS-8462
>                 URL: https://issues.apache.org/jira/browse/HDFS-8462
>             Project: Hadoop HDFS
>          Issue Type: New Feature
>            Reporter: Akira AJISAKA
>            Assignee: Jagadesh Kiran N
>         Attachments: HDFS-8462-00.patch, HDFS-8462-01.patch, 
> HDFS-8462-02.patch
>
>
> In Hadoop 2.7.0, WebImageViewer supports the following operations:
> * {{GETFILESTATUS}}
> * {{LISTSTATUS}}
> * {{GETACLSTATUS}}
> I'm thinking it would be better for administrators if {{GETXATTRS}} and 
> {{LISTXATTRS}} are supported.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to