[ 
https://issues.apache.org/jira/browse/HDFS-8659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14602173#comment-14602173
 ] 

Colin Patrick McCabe commented on HDFS-8659:
--------------------------------------------

The if statements should not be necessary, for two reasons:
1. slf4j doesn't create new strings through concatenation unless the log is 
enabled (this is ignoring things like the overhead of {{VolumeScanner#toString}}
2. These are not code paths we should hit often, since they are for handling 
I/O errors and starting up.

+1 once that's fixed.

thanks, [~yzhangal].

> Block scanner INFO message is spamming logs
> -------------------------------------------
>
>                 Key: HDFS-8659
>                 URL: https://issues.apache.org/jira/browse/HDFS-8659
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: datanode
>    Affects Versions: 2.7.1
>            Reporter: Yongjun Zhang
>            Assignee: Yongjun Zhang
>              Labels: supportability
>         Attachments: HDFS-8659.001.patch
>
>
> We are seeing the following message spam the DN log:
> {quote}
> 2015-06-16 08:51:10,566 INFO 
> org.apache.hadoop.hdfs.server.datanode.BlockScanner: Not scanning suspicious 
> block BP-943360218-10.106.148.16-1416571803827:blk_1083076388_9372245 on 
> DS-2ec89056-afb0-459e-b4e0-ac5eaececda3, because the block scanner is 
> disabled.
> {quote}
> Create this jira to change this and other relevant messages to debug level.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to