[ https://issues.apache.org/jira/browse/HDFS-8546?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrew Wang updated HDFS-8546: ------------------------------ Resolution: Fixed Fix Version/s: 2.8.0 Status: Resolved (was: Patch Available) Thanks [~eddyxu] for final review, [~szetszwo] for earlier ones. Committed to trunk and branch-2. > Use try with resources in DataStorage and Storage > ------------------------------------------------- > > Key: HDFS-8546 > URL: https://issues.apache.org/jira/browse/HDFS-8546 > Project: Hadoop HDFS > Issue Type: Improvement > Components: datanode > Affects Versions: 2.7.0 > Reporter: Andrew Wang > Assignee: Andrew Wang > Priority: Minor > Fix For: 2.8.0 > > Attachments: HDFS-8546.001.patch, HDFS-8546.002.patch, > HDFS-8546.003.patch, HDFS-8546.004.patch, HDFS-8546.005.patch, > HDFS-8546.006.patch > > > We have some old-style try/finally to close files in DataStorage and Storage, > let's update them. > Also a few small cleanups: > * Actually check that tryLock returns a FileLock in isPreUpgradableLayout > * Remove unused parameter from writeProperties > * Add braces for one-line if statements per coding style -- This message was sent by Atlassian JIRA (v6.3.4#6332)