[ 
https://issues.apache.org/jira/browse/HDFS-1476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12932796#action_12932796
 ] 

Patrick Kling commented on HDFS-1476:
-------------------------------------

{code}
     [exec] -1 overall.  
     [exec] 
     [exec]     +1 @author.  The patch does not contain any @author tags.
     [exec] 
     [exec]     +1 tests included.  The patch appears to include 6 new or 
modified tests.
     [exec] 
     [exec]     +1 javadoc.  The javadoc tool did not generate any warning 
messages.
     [exec] 
     [exec]     +1 javac.  The applied patch does not increase the total number 
of javac compiler warnings.
     [exec] 
     [exec]     -1 findbugs.  The patch appears to introduce 3 new Findbugs 
warnings.
     [exec] 
     [exec]     -1 release audit.  The applied patch generated 97 release audit 
warnings (more than the trunk's current 1 warnings).
     [exec] 
     [exec]     +1 system test framework.  The patch passed system test 
framework compile.
{code}

The findbugs/release audit warnings are caused by the issue described in 
MAPREDUCE-2172.

> listCorruptFileBlocks should be functional while the name node is still in 
> safe mode
> ------------------------------------------------------------------------------------
>
>                 Key: HDFS-1476
>                 URL: https://issues.apache.org/jira/browse/HDFS-1476
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>            Reporter: Patrick Kling
>            Assignee: Patrick Kling
>         Attachments: HDFS-1476.2.patch, HDFS-1476.patch
>
>
> This would allow us to detect whether missing blocks can be fixed using Raid 
> and if that is the case exit safe mode earlier.
> One way to make listCorruptFileBlocks available before the name node has 
> exited from safe mode would be to perform a scan of the blocks map on each 
> call to listCorruptFileBlocks to determine if there are any blocks with no 
> replicas. This scan could be parallelized by dividing the space of block IDs 
> into multiple intervals than can be scanned independently.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to