[
https://issues.apache.org/jira/browse/HDFS-8661?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Arpit Agarwal updated HDFS-8661:
--------------------------------
Attachment: v03-v04.diff
Thank you for the review [~kanaka].
bq. As per my understanding at present every NS should have a dataset mapped.
Every NS should have at least one dataset mapped but e.g. Ozone NS will not
apply to FsDatasetImpl, so the else clause is not an error. The log statement
was added for my debugging and left in error, I've removed it now.
bq. shall we improve the logging with nsInfos also to trace that all the block
pools from Ozone & File system registered on this volume
Good idea. Updated the log statement to log the list of NameSpaceInfos passed
in.
The attached file v03-v04.diff shows the delta between the .03 and .04 patches.
Updated .04 patch attached.
> DataNode should filter the set of NameSpaceInfos passed to Datasets
> -------------------------------------------------------------------
>
> Key: HDFS-8661
> URL: https://issues.apache.org/jira/browse/HDFS-8661
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: datanode
> Affects Versions: HDFS-7240
> Reporter: Arpit Agarwal
> Assignee: Arpit Agarwal
> Attachments: HDFS-8661-HDFS-7240.01.patch,
> HDFS-8661-HDFS-7240.02.patch, HDFS-8661-HDFS-7240.03.patch,
> HDFS-8661-HDFS-7240.04.patch, v03-v04.diff
>
>
> {{DataNode#refreshVolumes}} passes the list of NamespaceInfos to each dataset
> when adding new volumes.
> This list should be filtered by the correct NodeType(s) for each dataset.
> e.g. in a shared HDFS+Ozone cluster, FsDatasets would be notified of NN block
> pools and Ozone datasets would be notified of Ozone block pool(s).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
