[ 
https://issues.apache.org/jira/browse/HDFS-8751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14622861#comment-14622861
 ] 

Zhe Zhang commented on HDFS-8751:
---------------------------------

Thanks Jing for reviewing! {{testDatanodeRestarts}} is unrelated to the patch 
(the only non-formatting change is to replace all {{setBlocks(null)}} with 
{{clearBlocks()}}, and it passes locally.

> Remove setBlocks API from INodeFile and misc code cleanup
> ---------------------------------------------------------
>
>                 Key: HDFS-8751
>                 URL: https://issues.apache.org/jira/browse/HDFS-8751
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: namenode
>    Affects Versions: 2.7.0
>            Reporter: Zhe Zhang
>            Assignee: Zhe Zhang
>             Fix For: 2.8.0
>
>         Attachments: HDFS-8751.00.patch, HDFS-8751.01.patch
>
>
> The public {{INodeFile#setBlocks}} API, when used outside {{INodeFile}}, is 
> always called with {{null}}. Therefore we should replace it with a safer 
> {{clearBlocks}} API. Also merging code cleanups from HDFS-7285 branch.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to