[
https://issues.apache.org/jira/browse/HDFS-1473?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Todd Lipcon updated HDFS-1473:
------------------------------
Attachment: hdfs-1473.txt
Here's the same patch plus a findbugs exclusion. For whatever reason, findbugs
seems to think that the finally { out.close() } in the FSImage write function
won't close the underlying streams. Since it's a FilterOutputStream, it does
pass the close() down.
The unit test results are same as posted above. Here's test-patch:
[exec] +1 overall.
[exec]
[exec] +1 @author. The patch does not contain any @author tags.
[exec]
[exec] +1 tests included. The patch appears to include 3 new or
modified tests.
[exec]
[exec] +1 javadoc. The javadoc tool did not generate any warning
messages.
[exec]
[exec] +1 javac. The applied patch does not increase the total number
of javac compiler warnings.
[exec]
[exec] +1 findbugs. The patch does not introduce any new Findbugs
(version 1.3.9) warnings.
[exec]
[exec] +1 release audit. The applied patch does not increase the
total number of release audit warnings.
[exec]
[exec] +1 system test framework. The patch passed system test
framework compile.
> Refactor storage management into separate classes than fsimage file
> reading/writing
> -----------------------------------------------------------------------------------
>
> Key: HDFS-1473
> URL: https://issues.apache.org/jira/browse/HDFS-1473
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Attachments: hdfs-1473-prelim.txt, hdfs-1473.txt, hdfs-1473.txt
>
>
> Currently the FSImage class is responsible both for storage management (eg
> moving around files, tracking file names, the VERSION file, etc) as well as
> for the actual serialization and deserialization of the "fsimage" file within
> the storage directory.
> I'd like to refactor the loading and saving code into new classes. This will
> make testing easier and also make the major changes in HDFS-1073 easier to
> understand.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
