[ 
https://issues.apache.org/jira/browse/HDFS-8811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14645484#comment-14645484
 ] 

Yi Liu commented on HDFS-8811:
------------------------------

Thanks Vinay for working on this.

I agree all the constants of policy names should be better put in one place.  
Currently {{MEMORY_STORAGE_POLICY_NAME}} is used in client side.  So we should 
put them in {{HdfsConstants.java}}.   

+1 for the patch.


> Move BlockStoragePolicy name's constants from HdfsServerConstants.java to 
> HdfsConstants.java
> --------------------------------------------------------------------------------------------
>
>                 Key: HDFS-8811
>                 URL: https://issues.apache.org/jira/browse/HDFS-8811
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>            Reporter: Vinayakumar B
>            Assignee: Vinayakumar B
>         Attachments: HDFS-8811-01.patch
>
>
> Currently {{HdfsServerConstants.java}} have following constants, 
> {code}  String HOT_STORAGE_POLICY_NAME = "HOT";
>   String WARM_STORAGE_POLICY_NAME = "WARM";
>   String COLD_STORAGE_POLICY_NAME = "COLD";{code}
> and {{HdfsConstants.java}} have the following
> {code}  public static final String MEMORY_STORAGE_POLICY_NAME = 
> "LAZY_PERSIST";
>   public static final String ALLSSD_STORAGE_POLICY_NAME = "ALL_SSD";
>   public static final String ONESSD_STORAGE_POLICY_NAME = "ONE_SSD";{code}
> It would be better to move all these to one place HdfsConstants.java, which 
> client APIs also could access since this presents in hdfs-client module.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to