[
https://issues.apache.org/jira/browse/HDFS-8835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14649906#comment-14649906
]
Andrew Wang commented on HDFS-8835:
-----------------------------------
There is a lot of past precedent for doing refactors in trunk. One of the first
EC-related changes was HDFS-7743 which renamed BlockInfo to BlockInfoContiguous
in trunk. [~szetszwo] you +1'd this change. The other BlockInfo refactors have
happened over many weeks and been reviewed by a variety of different committers
(Yi, Vinay, Jing, myself) so there has been no intent to "sneak" changes into
trunk. Considering the number of positive reviews, I would say doing refactors
in trunk has been met with general approval.
bq. Patches got committed to trunk neither means that everyone already has
understood the code
Everyone understanding the code is not a prerequisite for getting code
committed. Part of community over code is trusting the judgement of the other
committers on the project. Here multiple committers have positively reviewed
these refactors.
bq. Quite a few people told me that the recent change of HDFS-8487 does make
the code harder to understand. It makes the familiar code unfamiliar.
Considering that many of us have positively reviewed these refactors, maybe
"harder to understand" is a matter of opinion.
Zhe posted about plans to further simplify the code through use of composition.
Would this help with reviewing the sum of the changes? Maybe we should also
continue to discuss the design of the hierarchy over on HDFS-8499.
> Convert BlockInfoUnderConstruction as an interface
> --------------------------------------------------
>
> Key: HDFS-8835
> URL: https://issues.apache.org/jira/browse/HDFS-8835
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: namenode
> Affects Versions: 2.7.1
> Reporter: Zhe Zhang
> Assignee: Zhe Zhang
>
> Per discussion under HDFS-8499, this JIRA aims to convert
> {{BlockInfoUnderConstruction}} as an interface and
> {{BlockInfoContiguousUnderConstruction}} as its implementation. The HDFS-7285
> branch will add {{BlockInfoStripedUnderConstruction}} as another
> implementation.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
