[ https://issues.apache.org/jira/browse/HDFS-1508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12967113#action_12967113 ]
Hairong Kuang commented on HDFS-1508: ------------------------------------- The patch looks good. Only a couple of minor comments: 1. DFSAdmin#saveNamespace's javadoc should update the sections "Usage" and "@see". 2. TestSaveNamespace#testSaveWhileEditsRolledNotInSafemode could save a few lines if it uses Assert#fail after testSaveWhileEditsRolled instead of using gotException. > Ability to do savenamespace without being in safemode > ----------------------------------------------------- > > Key: HDFS-1508 > URL: https://issues.apache.org/jira/browse/HDFS-1508 > Project: Hadoop HDFS > Issue Type: Improvement > Components: name-node > Reporter: dhruba borthakur > Assignee: dhruba borthakur > Attachments: savenamespaceWithoutSafemode.txt, > savenamespaceWithoutSafemode2.txt, savenamespaceWithoutSafemode3.txt > > > In the current code, the administrator can run savenamespace only after > putting the namenode in safemode. This means that applications that are > writing to HDFS encounters errors because the NN is in safemode. We would > like to allow saveNamespace even when the namenode is not in safemode. > The savenamespace command already acquires the FSNamesystem writelock. There > is no need to require that the namenode is in safemode too. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.