[ https://issues.apache.org/jira/browse/HDFS-8856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14658770#comment-14658770 ]
Xiaoyu Yao commented on HDFS-8856: ---------------------------------- Patch v2 looks good to me. +1 One nit: you can use a timeout rule that applies to all cases instead of adding them individually. {code} @Rule publicTimeout timeout=new Timeout(300000); {code} > Make LeaseManager#countPath O(1) > -------------------------------- > > Key: HDFS-8856 > URL: https://issues.apache.org/jira/browse/HDFS-8856 > Project: Hadoop HDFS > Issue Type: Bug > Components: namenode > Affects Versions: 2.7.2 > Reporter: Arpit Agarwal > Assignee: Arpit Agarwal > Attachments: HDFS-8856.01.patch, HDFS-8856.02.patch > > > {{LeaseManager#countPath}} loops over all existing lease holders to compute > the pending lease count. We can just track the pending leased files so it > runs in constant time. -- This message was sent by Atlassian JIRA (v6.3.4#6332)