[ https://issues.apache.org/jira/browse/HDFS-1532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12969127#action_12969127 ]
Todd Lipcon commented on HDFS-1532: ----------------------------------- [exec] +1 overall. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] +1 tests included. The patch appears to include 3 new or modified tests. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings. [exec] [exec] +1 system test framework. The patch passed system test framework compile. [exec] [exec] > Exclude Findbugs warning in FSImageFormat$Saver > ----------------------------------------------- > > Key: HDFS-1532 > URL: https://issues.apache.org/jira/browse/HDFS-1532 > Project: Hadoop HDFS > Issue Type: Bug > Components: test > Affects Versions: 0.22.0 > Reporter: Todd Lipcon > Assignee: Todd Lipcon > Fix For: 0.22.0 > > Attachments: findbugs-fix.txt > > > HDFS-1473 had a followup patch which changed a method name, but I forgot to > modify the findbugs exclude file to match. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.