[
https://issues.apache.org/jira/browse/HDFS-8909?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jing Zhao updated HDFS-8909:
----------------------------
Attachment: HDFS-8909.001.patch
Thanks for the review, Zhe! Update the patch to address your comments.
bq. separate ReplicaUnderConstruction
Currently I prefer separating it out as a standalone class. Maybe we can do it
also in trunk.
bq. a contiguous block should not have different IDs reported. Should we add
some assertion to be more clear
Here the issue is the BlockUnderConstructionFeature itself does not know if
this is striped or not, thus there is no way to do extra verification. But
since the reported block is added a replica only if its block id is mapped to
the BlockInfo object, I do not think we need to add extra assertion here.
bq. simplify BlockInfo#convertToBlockUnderConstruction
Currently I want to make sure when we create a BlockUCFeature, the expected
locations are already passed in. Thus I leave the storage array in the
constructor parameter list. But please let me know if you have a strong feeling
about it.
> Erasure coding: update BlockInfoContiguousUC and BlockInfoStripedUC to use
> BlockUnderConstructionFeature
> --------------------------------------------------------------------------------------------------------
>
> Key: HDFS-8909
> URL: https://issues.apache.org/jira/browse/HDFS-8909
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: namenode
> Affects Versions: HDFS-7285
> Reporter: Zhe Zhang
> Assignee: Jing Zhao
> Attachments: HDFS-8909.000.patch, HDFS-8909.001.patch
>
>
> HDFS-8801 converts {{BlockInfoUC}} as a feature. We should consolidate
> {{BlockInfoContiguousUC}} and {{BlockInfoStripedUC}} logics to use this
> feature.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
