[ https://issues.apache.org/jira/browse/HDFS-8900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14710483#comment-14710483 ]
Andrew Wang commented on HDFS-8900: ----------------------------------- I like the PACK_THRESHOLD as a solution, doesn't change the core of the patch and I see there's some unittest coverage. I'm +1 still, thanks for working on this Yi and reviewing Brahma. > Compact XAttrs to optimize memory footprint. > -------------------------------------------- > > Key: HDFS-8900 > URL: https://issues.apache.org/jira/browse/HDFS-8900 > Project: Hadoop HDFS > Issue Type: Improvement > Components: namenode > Reporter: Yi Liu > Assignee: Yi Liu > Attachments: HDFS-8900.001.patch, HDFS-8900.002.patch, > HDFS-8900.003.patch, HDFS-8900.004.patch, HDFS-8900.005.patch > > > {code} > private final ImmutableList<XAttr> xAttrs; > {code} > Currently we use above in XAttrFeature, it's not efficient from memory point > of view, since {{ImmutableList}} and {{XAttr}} have object memory overhead, > and each object has memory alignment. > We can use a {{byte[]}} in XAttrFeature and do some compact in {{XAttr}}. -- This message was sent by Atlassian JIRA (v6.3.4#6332)