[ https://issues.apache.org/jira/browse/HDFS-1148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14711727#comment-14711727 ]
Hadoop QA commented on HDFS-1148: --------------------------------- \\ \\ | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:red}-1{color} | pre-patch | 18m 25s | Pre-patch trunk has 4 extant Findbugs (version 3.0.0) warnings. | | {color:green}+1{color} | @author | 0m 0s | The patch does not contain any @author tags. | | {color:green}+1{color} | tests included | 0m 0s | The patch appears to include 1 new or modified test files. | | {color:green}+1{color} | javac | 8m 0s | There were no new javac warning messages. | | {color:green}+1{color} | javadoc | 10m 5s | There were no new javadoc warning messages. | | {color:green}+1{color} | release audit | 0m 24s | The applied patch does not increase the total number of release audit warnings. | | {color:red}-1{color} | checkstyle | 1m 25s | The applied patch generated 1 new checkstyle issues (total was 121, now 111). | | {color:green}+1{color} | whitespace | 0m 3s | The patch has no lines that end in whitespace. | | {color:green}+1{color} | install | 1m 31s | mvn install still works. | | {color:green}+1{color} | eclipse:eclipse | 0m 34s | The patch built with eclipse:eclipse. | | {color:red}-1{color} | findbugs | 2m 1s | Post-patch findbugs hadoop-hdfs-project/hadoop-hdfs compilation is broken. | | {color:green}+1{color} | findbugs | 2m 1s | The patch does not introduce any new Findbugs (version ) warnings. | | {color:green}+1{color} | native | 0m 37s | Pre-build of native portion | | {color:red}-1{color} | hdfs tests | 6m 39s | Tests failed in hadoop-hdfs. | | | | 49m 49s | | \\ \\ || Reason || Tests || | Failed unit tests | hadoop.hdfs.TestFileStatus | \\ \\ || Subsystem || Report/Notes || | Patch URL | http://issues.apache.org/jira/secure/attachment/12752270/HDFS-1148.003.patch | | Optional Tests | javadoc javac unit findbugs checkstyle | | git revision | trunk / eee0d45 | | Pre-patch Findbugs warnings | https://builds.apache.org/job/PreCommit-HDFS-Build/12117/artifact/patchprocess/trunkFindbugsWarningshadoop-hdfs.html | | checkstyle | https://builds.apache.org/job/PreCommit-HDFS-Build/12117/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt | | hadoop-hdfs test log | https://builds.apache.org/job/PreCommit-HDFS-Build/12117/artifact/patchprocess/testrun_hadoop-hdfs.txt | | Test Results | https://builds.apache.org/job/PreCommit-HDFS-Build/12117/testReport/ | | Java | 1.7.0_55 | | uname | Linux asf909.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux | | Console output | https://builds.apache.org/job/PreCommit-HDFS-Build/12117/console | This message was automatically generated. > Convert FSDataset to ReadWriteLock > ---------------------------------- > > Key: HDFS-1148 > URL: https://issues.apache.org/jira/browse/HDFS-1148 > Project: Hadoop HDFS > Issue Type: Improvement > Components: datanode, performance > Reporter: Todd Lipcon > Assignee: Yong Zhang > Attachments: HDFS-1148.001.patch, HDFS-1148.002.patch, > HDFS-1148.003.patch, hdfs-1148-old.txt, hdfs-1148-trunk.txt, > patch-HDFS-1148-rel0.20.2.txt > > > In benchmarking HDFS-941 I noticed that for the random read workload, the > FSDataset lock is highly contended. After converting it to a > ReentrantReadWriteLock, I saw a ~25% improvement on both latency and > ops/second. -- This message was sent by Atlassian JIRA (v6.3.4#6332)