[ 
https://issues.apache.org/jira/browse/HDFS-8520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14711995#comment-14711995
 ] 

Andrew Wang commented on HDFS-8520:
-----------------------------------

Hi Tony,

My point is that we don't really have PPC64 support right now, things like 
caching haven't been tested on it AFAIK, and making tests use a variable rather 
than a hardcoded page size doesn't change the supported status. It certainly 
wouldn't add support for unknown architectures that have non-4096 and non-64KB 
page sizes. I proposed using a hardcoded 64KB to patch over this one test in 
the meantime. I have no way of validating a change to use 
getOperatingSystemPageSize() actually works on PPC64 since I don't have a PPC64 
test environment where it would return 64KB. Thus the hardcode.

If there's some big push to add PPC64 support, validate it, and get it in the 
precommit pool, then sure we can do it more generically.

> Patch for PPC64 block size
> --------------------------
>
>                 Key: HDFS-8520
>                 URL: https://issues.apache.org/jira/browse/HDFS-8520
>             Project: Hadoop HDFS
>          Issue Type: Bug
>    Affects Versions: 2.7.1
>         Environment: RHEL 7.1 /PPC64
>            Reporter: Tony Reix
>            Assignee: Tony Reix
>         Attachments: HDFS-8520-2.patch, HDFS-8520.patch
>
>
> The attached patch enables Hadoop to work on PPC64.
> That deals with SystemPageSize and BloclSize , which are not 4096 on PPC64.
> There are changes in 3 files:
> - 
> hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/nativeio/NativeIO.java
> - 
> hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestFsDatasetCache.java
> - 
> hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestCacheDirectives.java
> where 4096 is replaced by getOperatingSystemPageSize() or by using PAGE_SIZE
> The patch has been built on branch-2.7 .



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to