[ https://issues.apache.org/jira/browse/HDFS-8248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14712068#comment-14712068 ]
Hadoop QA commented on HDFS-8248: --------------------------------- \\ \\ | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:red}-1{color} | pre-patch | 17m 49s | Pre-patch trunk has 4 extant Findbugs (version 3.0.0) warnings. | | {color:green}+1{color} | @author | 0m 0s | The patch does not contain any @author tags. | | {color:green}+1{color} | tests included | 0m 0s | The patch appears to include 7 new or modified test files. | | {color:green}+1{color} | javac | 7m 56s | There were no new javac warning messages. | | {color:green}+1{color} | javadoc | 10m 7s | There were no new javadoc warning messages. | | {color:green}+1{color} | release audit | 0m 22s | The applied patch does not increase the total number of release audit warnings. | | {color:red}-1{color} | checkstyle | 1m 26s | The applied patch generated 3 new checkstyle issues (total was 512, now 510). | | {color:green}+1{color} | whitespace | 0m 3s | The patch has no lines that end in whitespace. | | {color:green}+1{color} | install | 1m 32s | mvn install still works. | | {color:green}+1{color} | eclipse:eclipse | 0m 34s | The patch built with eclipse:eclipse. | | {color:red}-1{color} | findbugs | 2m 8s | Post-patch findbugs hadoop-hdfs-project/hadoop-hdfs compilation is broken. | | {color:green}+1{color} | findbugs | 2m 8s | The patch does not introduce any new Findbugs (version 3.0.0) warnings. | | {color:green}+1{color} | native | 0m 22s | Pre-build of native portion | | {color:red}-1{color} | hdfs tests | 159m 41s | Tests failed in hadoop-hdfs. | | | | 202m 7s | | \\ \\ || Reason || Tests || | Failed unit tests | hadoop.hdfs.server.blockmanagement.TestNodeCount | | | hadoop.fs.TestHdfsNativeCodeLoader | | | hadoop.hdfs.server.blockmanagement.TestSequentialBlockId | \\ \\ || Subsystem || Report/Notes || | Patch URL | http://issues.apache.org/jira/secure/attachment/12752141/HDFS-8248.007.patch | | Optional Tests | javadoc javac unit findbugs checkstyle | | git revision | trunk / eee0d45 | | Pre-patch Findbugs warnings | https://builds.apache.org/job/PreCommit-HDFS-Build/12122/artifact/patchprocess/trunkFindbugsWarningshadoop-hdfs.html | | checkstyle | https://builds.apache.org/job/PreCommit-HDFS-Build/12122/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt | | hadoop-hdfs test log | https://builds.apache.org/job/PreCommit-HDFS-Build/12122/artifact/patchprocess/testrun_hadoop-hdfs.txt | | Test Results | https://builds.apache.org/job/PreCommit-HDFS-Build/12122/testReport/ | | Java | 1.7.0_55 | | uname | Linux asf900.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux | | Console output | https://builds.apache.org/job/PreCommit-HDFS-Build/12122/console | This message was automatically generated. > Store INodeId instead of the INodeFile object in BlockInfoContiguous > -------------------------------------------------------------------- > > Key: HDFS-8248 > URL: https://issues.apache.org/jira/browse/HDFS-8248 > Project: Hadoop HDFS > Issue Type: Improvement > Reporter: Haohui Mai > Assignee: Haohui Mai > Attachments: HDFS-8248.000.patch, HDFS-8248.001.patch, > HDFS-8248.002.patch, HDFS-8248.003.patch, HDFS-8248.004.patch, > HDFS-8248.005.patch, HDFS-8248.006.patch, HDFS-8248.007.patch > > > Currently the namespace and the block manager are tightly coupled together. > There are two couplings in terms of implementation: > 1. The {{BlockInfoContiguous}} stores a reference of the {{INodeFile}} that > owns the block, so that the block manager can look up the corresponding file > when replicating blocks, recovering from pipeline failures, etc. > 1. The {{INodeFile}} stores {{BlockInfoContiguous}} objects that the file > owns. > Decoupling the namespace and the block manager allows the BM to be separated > out from the Java heap or even as a standalone process. This jira proposes to > remove the first coupling by storing the id of the inode instead of the > object reference of {{INodeFile}} in the {{BlockInfoContiguous}} class. -- This message was sent by Atlassian JIRA (v6.3.4#6332)