[ https://issues.apache.org/jira/browse/HDFS-1543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12972726#action_12972726 ]
Konstantin Boudnik commented on HDFS-1543: ------------------------------------------ I steel feel like this is a pretty bad idea {noformat} - <antcall target="run-test-hdfs-fault-inject"/> {noformat} because it effectively means that certain parts of the code base won't be tested as a part of {{test-core}} despite the fact that a significant part of critical functionality is covered by these tests. Besides: {noformat} [junit] Tests run: 2, Failures: 0, Errors: 0, Time elapsed: 3.267 sec [junit] Running org.apache.hadoop.fs.TestFiRename [junit] Tests run: 4, Failures: 0, Errors: 0, Time elapsed: 11.839 sec [junit] Running org.apache.hadoop.hdfs.TestFiHFlush [junit] Tests run: 9, Failures: 0, Errors: 0, Time elapsed: 33.734 sec [junit] Running org.apache.hadoop.hdfs.TestFiHftp [junit] Tests run: 1, Failures: 0, Errors: 0, Time elapsed: 40.466 sec [junit] Running org.apache.hadoop.hdfs.TestFiPipelines [junit] Tests run: 3, Failures: 0, Errors: 0, Time elapsed: 9.31 sec [junit] Running org.apache.hadoop.hdfs.server.datanode.TestFiDataTransferProtocol [junit] Tests run: 29, Failures: 0, Errors: 0, Time elapsed: 271.976 sec [junit] Running org.apache.hadoop.hdfs.server.datanode.TestFiDataTransferProtocol2 [junit] Tests run: 10, Failures: 0, Errors: 0, Time elapsed: 415.231 sec [junit] Running org.apache.hadoop.hdfs.server.datanode.TestFiPipelineClose [junit] Tests run: 3, Failures: 0, Errors: 0, Time elapsed: 40.36 sec {noformat} E.g. 59 testcases are executed under 820 seconds (just over 13 mins). Making it about 12 seconds per test case. Which technically qualifies them to be unit tests according to HADOOP-6987). What I see though is that if {{ant run-test-hdfs-fault-inject}} execute the same set of tests 3 times. This needs to be fixed, but not by moving valid testing target out of the {{test-core}} scope. Moving si artifacts away from mvn-install seems to be ok. > Remove fault injection artifacts from the default build and push to maven for > HDFS > ---------------------------------------------------------------------------------- > > Key: HDFS-1543 > URL: https://issues.apache.org/jira/browse/HDFS-1543 > Project: Hadoop HDFS > Issue Type: Bug > Reporter: Arun C Murthy > Assignee: Luke Lu > Fix For: 0.22.0 > > Attachments: hdfs-1543-trunk-v1.patch > > > The current build always generates fault injection artifacts and pushes them > to Maven. Most developers have no need for these artifacts and no users need > them. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.