[
https://issues.apache.org/jira/browse/HDFS-8938?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mingliang Liu updated HDFS-8938:
--------------------------------
Description:
This jira tracks the effort of refactoring inner classes
{{BlockManager$BlockToMarkCorrupt}} and {{BlockManager$ReplicationWork}} in
{{hdfs.server.blockmanagement}} package. As the line number of {{BlockManager}}
is getting larger than 2000, we can move those two inner classes out of the it.
Meanwhile, the logic in method {{computeReplicationWorkForBlocks}} can be
simplified if we extract code sections to _schedule replication_ and to
_validate replication work_ to private helper methods respectively.
was:
This jira tracks the effort of refactoring inner classes
{{BlockManager$BlockToMarkCorrupt}} and {{BlockManager$ReplicationWork}} in
{{hdfs.server.blockmanagement}} package. As the line number of {{BlockManager}}
is getting larger than 2000, we can move those two inner classes out of the it.
Meanwhile, the logic in method {{computeReplicationWorkForBlocks}} can be
simplified if we extract code sections to _schedule replication_ and to
_validate replication work_ to private helper methods respectively.
> Refactor BlockManager in blockmanagement
> ----------------------------------------
>
> Key: HDFS-8938
> URL: https://issues.apache.org/jira/browse/HDFS-8938
> Project: Hadoop HDFS
> Issue Type: Task
> Components: build
> Reporter: Mingliang Liu
> Assignee: Mingliang Liu
> Attachments: HDFS-8938.000.patch, HDFS-8938.001.patch,
> HDFS-8938.002.patch, HDFS-8938.003.patch, HDFS-8938.004.patch,
> HDFS-8938.005.patch
>
>
> This jira tracks the effort of refactoring inner classes
> {{BlockManager$BlockToMarkCorrupt}} and {{BlockManager$ReplicationWork}} in
> {{hdfs.server.blockmanagement}} package. As the line number of
> {{BlockManager}} is getting larger than 2000, we can move those two inner
> classes out of the it.
> Meanwhile, the logic in method {{computeReplicationWorkForBlocks}} can be
> simplified if we extract code sections to _schedule replication_ and to
> _validate replication work_ to private helper methods respectively.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
