[ 
https://issues.apache.org/jira/browse/HDFS-1489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12972944#action_12972944
 ] 

Todd Lipcon commented on HDFS-1489:
-----------------------------------

Hi Ivan. I like the general ideas in the patch, but as is it's too big to 
review, and seems to partially revert some other patches that it conflicted 
with over the last few weeks. Do you think we could work together to split it 
into two or three smaller pieces? For example, maybe we can start with just the 
refactor for error handling?

> breaking the dependency between FSEditLog and FSImage
> -----------------------------------------------------
>
>                 Key: HDFS-1489
>                 URL: https://issues.apache.org/jira/browse/HDFS-1489
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: name-node
>    Affects Versions: 0.21.0
>            Reporter: Diego Marron
>         Attachments: HDFS-1489.diff, HDFS-1489.pdf
>
>
> This is a refactor patch which its main concerns are:
> - breaking the dependency between FSEditLog and FSImage
> - Splitting the abstracting the error handling and directory management, 
> - Decoupling Storage from FSImage.
> In order to accomplish the above goal, we will need to introduce new classes:
> -  NNStorage: Will care about the storage. It extends Storage class, and will 
> contain the StorageDirectories.
> -  NNUtils: Some utility static methods on FSImage and FSEditLog will be 
> moved here.
> -  PersistenceManager: FSNameSystem will now be responsible for managing the 
> FSImage & FSEditLog objects. There will be some logic that will have to moved 
> out of FSImage to facilite this. For this we propose a PersistanceManager? 
> object as follows.
> For more deep details, see the design document uploaded.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to