[ https://issues.apache.org/jira/browse/HDFS-1511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12973073#action_12973073 ]
Konstantin Boudnik commented on HDFS-1511: ------------------------------------------ +1 patch looks good and works as expected. A couple of optional nits: - replace commit-tests, all-tests, and so on with a mask like this {{<exclude name="src/test/*-tests" />}} - replace specific {{resources}} folder location with something like {{<exclude name="**/*/resources/" /> }} This will allow not to update the exclude list everytime a new test list or resources folder is added into the source tree. - keeping the exclude list outside of the build.xml looked more appealing to me, but having it embedded into the build file is Ok too. > 98 Release Audit warnings on trunk and branch-0.22 > -------------------------------------------------- > > Key: HDFS-1511 > URL: https://issues.apache.org/jira/browse/HDFS-1511 > Project: Hadoop HDFS > Issue Type: Bug > Affects Versions: 0.22.0, 0.23.0 > Reporter: Nigel Daley > Priority: Blocker > Fix For: 0.22.0, 0.23.0 > > Attachments: HDFS-1511.patch, HDFS-1511.patch, > releaseauditWarnings.txt > > > There are 98 release audit warnings on trunk. See attached txt file. These > must be fixed or filtered out to get back to a reasonably small number of > warnings. The OK_RELEASEAUDIT_WARNINGS property in > src/test/test-patch.properties should also be set appropriately in the patch > that fixes this issue. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.