[ https://issues.apache.org/jira/browse/HDFS-8938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14717606#comment-14717606 ]
Hadoop QA commented on HDFS-8938: --------------------------------- \\ \\ | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:red}-1{color} | pre-patch | 17m 51s | Pre-patch trunk has 4 extant Findbugs (version 3.0.0) warnings. | | {color:green}+1{color} | @author | 0m 0s | The patch does not contain any @author tags. | | {color:red}-1{color} | tests included | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | | {color:green}+1{color} | javac | 7m 58s | There were no new javac warning messages. | | {color:green}+1{color} | javadoc | 10m 9s | There were no new javadoc warning messages. | | {color:green}+1{color} | release audit | 0m 24s | The applied patch does not increase the total number of release audit warnings. | | {color:red}-1{color} | checkstyle | 1m 22s | The applied patch generated 1 new checkstyle issues (total was 311, now 292). | | {color:red}-1{color} | whitespace | 0m 0s | The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix. | | {color:green}+1{color} | install | 1m 29s | mvn install still works. | | {color:green}+1{color} | eclipse:eclipse | 0m 33s | The patch built with eclipse:eclipse. | | {color:green}+1{color} | findbugs | 2m 30s | The patch does not introduce any new Findbugs (version 3.0.0) warnings, and fixes 1 pre-existing warnings. | | {color:green}+1{color} | native | 3m 12s | Pre-build of native portion | | {color:red}-1{color} | hdfs tests | 161m 30s | Tests failed in hadoop-hdfs. | | | | 207m 1s | | \\ \\ || Reason || Tests || | Failed unit tests | hadoop.hdfs.server.blockmanagement.TestBlockManager | | | hadoop.hdfs.TestRenameWhileOpen | \\ \\ || Subsystem || Report/Notes || | Patch URL | http://issues.apache.org/jira/secure/attachment/12752818/HDFS-8938.006.patch | | Optional Tests | javadoc javac unit findbugs checkstyle | | git revision | trunk / 90fe7bc | | Pre-patch Findbugs warnings | https://builds.apache.org/job/PreCommit-HDFS-Build/12169/artifact/patchprocess/trunkFindbugsWarningshadoop-hdfs.html | | checkstyle | https://builds.apache.org/job/PreCommit-HDFS-Build/12169/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt | | whitespace | https://builds.apache.org/job/PreCommit-HDFS-Build/12169/artifact/patchprocess/whitespace.txt | | hadoop-hdfs test log | https://builds.apache.org/job/PreCommit-HDFS-Build/12169/artifact/patchprocess/testrun_hadoop-hdfs.txt | | Test Results | https://builds.apache.org/job/PreCommit-HDFS-Build/12169/testReport/ | | Java | 1.7.0_55 | | uname | Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux | | Console output | https://builds.apache.org/job/PreCommit-HDFS-Build/12169/console | This message was automatically generated. > Refactor BlockManager in blockmanagement > ---------------------------------------- > > Key: HDFS-8938 > URL: https://issues.apache.org/jira/browse/HDFS-8938 > Project: Hadoop HDFS > Issue Type: Task > Components: build > Reporter: Mingliang Liu > Assignee: Mingliang Liu > Attachments: HDFS-8938.000.patch, HDFS-8938.001.patch, > HDFS-8938.002.patch, HDFS-8938.003.patch, HDFS-8938.004.patch, > HDFS-8938.005.patch, HDFS-8938.006.patch, HDFS-8938.007.patch > > > This jira tracks the effort of refactoring inner classes > {{BlockManager$BlockToMarkCorrupt}} and {{BlockManager$ReplicationWork}} in > {{hdfs.server.blockmanagement}} package. As the line number of > {{BlockManager}} is getting larger than 2000, we can move those two inner > classes out of the it. > Meanwhile, the logic in method {{computeReplicationWorkForBlocks}} can be > simplified if we extract code sections to _schedule replication_ and to > _validate replication work_ to private helper methods respectively. -- This message was sent by Atlassian JIRA (v6.3.4#6332)