[ 
https://issues.apache.org/jira/browse/HDFS-8990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14720812#comment-14720812
 ] 

Mingliang Liu commented on HDFS-8990:
-------------------------------------

Thanks [~wheat9]!

The wrong constant typo was because of the auto-completion in IDE. I should 
have been more careful when moving constants.

The {{TCP_WINDOW_SIZE}} is now in {{RemoteBlockReader2}} class as a static 
final int type constant in patch v1.

> Move RemoteBlockReader to hdfs-client module
> --------------------------------------------
>
>                 Key: HDFS-8990
>                 URL: https://issues.apache.org/jira/browse/HDFS-8990
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: build
>            Reporter: Mingliang Liu
>            Assignee: Mingliang Liu
>         Attachments: HDFS-8990.000.patch, HDFS-8990.001.patch
>
>
> This jira tracks the effort of moving the {{RemoteBlockReader}} class into 
> the {{hdfs-client}} module. {{BlockReader}} interface and 
> {{BlockReaderLocal}} class were moved to {{hadoop-hdfs-client}} module in 
> jira [HDFS-8925|https://issues.apache.org/jira/browse/HDFS-8925].
> The extant checkstyle warnings can be fixed in 
> [HDFS-8979|https://issues.apache.org/jira/browse/HDFS-8979]. While we need to 
> replace the _log4j_ with _slf4j_ in this patch, we track the effort of 
> removing the guards when calling LOG.debug() and LOG.trace() in jira 
> [HDFS-8971|https://issues.apache.org/jira/browse/HDFS-8971].



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to