[ https://issues.apache.org/jira/browse/HDFS-9002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14729880#comment-14729880 ]
Haohui Mai commented on HDFS-9002: ---------------------------------- Thanks. It looks good overall. {code} +++ b/hadoop-hdfs-project/hadoop-hdfs-client/dev-support/findbugsExcludeFile.xml @@ -14,6 +14,7 @@ <Class name="org.apache.hadoop.hdfs.protocol.SnapshotDiffReport$DiffReportEntry"/> <Class name="org.apache.hadoop.hdfs.protocol.SnapshottableDirectoryStatus"/> <Class name="org.apache.hadoop.hdfs.server.protocol.DatanodeStorageReport"/> + <Class name="org.apache.hadoop.hdfs.protocol.datatransfer.sasl.SaslResponseWithNegotiatedCipherOption"/> </Or> <Bug pattern="EI_EXPOSE_REP,EI_EXPOSE_REP2" /> </Match> {code} The entry should be removed in {{hadoop-hdfs/dev-support/findbugsExcludeFile.xml}}. +1 after addressing this. > Move o.a.h.hdfs.net/*Peer classes to client module > -------------------------------------------------- > > Key: HDFS-9002 > URL: https://issues.apache.org/jira/browse/HDFS-9002 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: build > Reporter: Mingliang Liu > Assignee: Mingliang Liu > Attachments: HDFS-9002.000.patch, HDFS-9002.001.patch, > HDFS-9002.002.patch, HDFS-9002.003.patch > > > This jira tracks the effort of moving the following two parts to > {{hadoop-hdfs-client}} module: > * {{*Peer.java}} classes > * static helper methods in {{TcpPeerServer}} > In {{org.apache.hadoop.hdfs.net}} package, the {{Peer}} classes should be > moved to {{hadoop-hdfs-client}} module as they are used in client, while > {{PeerServer}} classes stay in {{hadoop-hdfs}} module. For the static helper > methods in {{TcpPeerServer}}, we need to move them out of the > {{TcpPeerServer}} class and put them in client module. > Meanwhile, we need to move the related classes in > {{org.apache.hadoop.hdfs.protocol.datatransfer.sasl}} packages as they're > used by client module. Config keys should also be moved. > The checkstyle warnings can be addressed in [HDFS-8979 | > https://issues.apache.org/jira/browse/HDFS-8979], and removing the _slf4j_ > logger guards when calling {{LOG.debug()}} and {{LOG.trace()}} can be > addressed in [HDFS-8971 | https://issues.apache.org/jira/browse/HDFS-8971]. -- This message was sent by Atlassian JIRA (v6.3.4#6332)