[
https://issues.apache.org/jira/browse/HDFS-6955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14730558#comment-14730558
]
Vinayakumar B commented on HDFS-6955:
-------------------------------------
Thanks [~kanaka] for taking up the issue.
Patch looks almost good.
Some nits.
1. I think releasing reservation in {{cleanupBlock()}} not required. As by the
time this method is called in {{BlockReceiver}}, already reserved space will be
released. So this would release again.
2. Since Now reservation is for both RBW and Temp files, renaming
{{TestRbwSpaceReservation.java}} to something like
{{TestSpaceReservation.java}} would be a good idea IMO. If you feel existing is
fine, then no issues.
[~arpitagarwal], Do you also want to take a look at the patch.?
> DN should reserve disk space for a full block when creating tmp files
> ---------------------------------------------------------------------
>
> Key: HDFS-6955
> URL: https://issues.apache.org/jira/browse/HDFS-6955
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: datanode
> Affects Versions: 2.5.0
> Reporter: Arpit Agarwal
> Assignee: Kanaka Kumar Avvaru
> Attachments: HDFS-6955-01.patch, HDFS-6955-02.patch,
> HDFS-6955-03.patch, HDFS-6955-04.patch
>
>
> HDFS-6898 is introducing disk space reservation for RBW files to avoid
> running out of disk space midway through block creation.
> This Jira is to introduce similar reservation for tmp files.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
