[ https://issues.apache.org/jira/browse/HDFS-9022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14731337#comment-14731337 ]
Hadoop QA commented on HDFS-9022: --------------------------------- \\ \\ | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | pre-patch | 20m 57s | Pre-patch trunk compilation is healthy. | | {color:green}+1{color} | @author | 0m 0s | The patch does not contain any @author tags. | | {color:green}+1{color} | tests included | 0m 0s | The patch appears to include 13 new or modified test files. | | {color:green}+1{color} | javac | 7m 54s | There were no new javac warning messages. | | {color:green}+1{color} | javadoc | 10m 12s | There were no new javadoc warning messages. | | {color:green}+1{color} | release audit | 0m 23s | The applied patch does not increase the total number of release audit warnings. | | {color:green}+1{color} | checkstyle | 3m 22s | There were no new checkstyle issues. | | {color:green}+1{color} | whitespace | 0m 3s | The patch has no lines that end in whitespace. | | {color:green}+1{color} | install | 1m 41s | mvn install still works. | | {color:green}+1{color} | eclipse:eclipse | 0m 32s | The patch built with eclipse:eclipse. | | {color:green}+1{color} | findbugs | 6m 6s | The patch does not introduce any new Findbugs (version 3.0.0) warnings. | | {color:green}+1{color} | native | 3m 13s | Pre-build of native portion | | {color:red}-1{color} | mapreduce tests | 80m 51s | Tests failed in hadoop-mapreduce-client-jobclient. | | {color:red}-1{color} | hdfs tests | 0m 31s | Tests failed in hadoop-hdfs. | | {color:green}+1{color} | hdfs tests | 0m 32s | Tests passed in hadoop-hdfs-client. | | {color:red}-1{color} | hdfs tests | 1m 7s | Tests failed in hadoop-hdfs-nfs. | | | | 137m 28s | | \\ \\ || Reason || Tests || | Failed unit tests | hadoop.mapreduce.v2.TestMRJobs | | | hadoop.mapreduce.security.TestMRCredentials | | | hadoop.hdfs.nfs.nfs3.TestWrites | | | hadoop.hdfs.nfs.TestMountd | | | hadoop.hdfs.nfs.nfs3.TestExportsTable | | | hadoop.hdfs.nfs.nfs3.TestRpcProgramNfs3 | | | hadoop.hdfs.nfs.nfs3.TestReaddir | | | hadoop.hdfs.nfs.nfs3.TestClientAccessPrivilege | | | hadoop.hdfs.nfs.nfs3.TestNfs3HttpServer | | Timed out tests | org.apache.hadoop.mapreduce.v2.TestSpeculativeExecution | | | org.apache.hadoop.mapreduce.TestMapReduceLazyOutput | | Failed build | hadoop-hdfs | \\ \\ || Subsystem || Report/Notes || | Patch URL | http://issues.apache.org/jira/secure/attachment/12754230/HDFS-9022.001.patch | | Optional Tests | javadoc javac unit findbugs checkstyle | | git revision | trunk / 6eaca2e | | hadoop-mapreduce-client-jobclient test log | https://builds.apache.org/job/PreCommit-HDFS-Build/12309/artifact/patchprocess/testrun_hadoop-mapreduce-client-jobclient.txt | | hadoop-hdfs test log | https://builds.apache.org/job/PreCommit-HDFS-Build/12309/artifact/patchprocess/testrun_hadoop-hdfs.txt | | hadoop-hdfs-client test log | https://builds.apache.org/job/PreCommit-HDFS-Build/12309/artifact/patchprocess/testrun_hadoop-hdfs-client.txt | | hadoop-hdfs-nfs test log | https://builds.apache.org/job/PreCommit-HDFS-Build/12309/artifact/patchprocess/testrun_hadoop-hdfs-nfs.txt | | Test Results | https://builds.apache.org/job/PreCommit-HDFS-Build/12309/testReport/ | | Java | 1.7.0_55 | | uname | Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux | | Console output | https://builds.apache.org/job/PreCommit-HDFS-Build/12309/console | This message was automatically generated. > Move NameNode.getAddress() and NameNode.getUri() to hadoop-hdfs-client > ---------------------------------------------------------------------- > > Key: HDFS-9022 > URL: https://issues.apache.org/jira/browse/HDFS-9022 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: hdfs-client, namenode > Reporter: Mingliang Liu > Assignee: Mingliang Liu > Attachments: HDFS-9022.000.patch, HDFS-9022.001.patch > > > The static helper methods in NameNodes are used in {{hdfs-client}} module. > For example, it's used by the {{DFSClient}} and {{NameNodeProxies}} classes > which are being moved to {{hadoop-hdfs-client}} module. Meanwhile, we should > keep the {{NameNode}} class itself in the {{hadoop-hdfs}} module. > This jira tracks the effort of moving the following static helper methods out > of {{NameNode}} and thus {{hadoop-hdfs}} module. A good place to put these > methods is the {{DFSUtilClient}} class: > {code} > public static InetSocketAddress getAddress(String address); > public static InetSocketAddress getAddress(Configuration conf); > public static InetSocketAddress getAddress(URI filesystemURI); > public static URI getUri(InetSocketAddress namenode); > {code} > Be cautious not to bring new checkstyle warnings. -- This message was sent by Atlassian JIRA (v6.3.4#6332)