[ 
https://issues.apache.org/jira/browse/HDFS-9065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14742164#comment-14742164
 ] 

Haohui Mai commented on HDFS-9065:
----------------------------------

The patch looks good.

{code}
{@addFmtNum key="{FilesTotal}" operand="{BlocksTotal}"/}
{code}

Instead of having a new helper, you can calculate the total number of objects 
in JavaScript, then format it using the same formatter. Please see HDFS-8816 
for more details.


> Include commas on # of files, blocks, total filesystem objects in NN Web UI
> ---------------------------------------------------------------------------
>
>                 Key: HDFS-9065
>                 URL: https://issues.apache.org/jira/browse/HDFS-9065
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: HDFS
>    Affects Versions: 2.7.1
>            Reporter: Daniel Templeton
>            Assignee: Daniel Templeton
>            Priority: Minor
>         Attachments: HDFS-9065.001.patch, HDFS-9065.002.patch
>
>
> Include commas on the number of files, blocks, and total filesystem objects 
> in the NN Web UI (please see example below) to make the numbers easier to 
> read.
> Current format:
> 3236 files and directories, 1409 blocks = 4645 total filesystem object(s).
> Proposed format:
> 3,236 files and directories, 1,409 blocks = 4,645 total filesystem object(s).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to