[
https://issues.apache.org/jira/browse/HDFS-9008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14745909#comment-14745909
]
Hudson commented on HDFS-9008:
------------------------------
FAILURE: Integrated in Hadoop-trunk-Commit #8455 (See
[https://builds.apache.org/job/Hadoop-trunk-Commit/8455/])
HDFS-9008. Balancer#Parameters class could use a builder pattern. (Chris Trezzo
via mingma) (mingma: rev 083b44c136ea5aba660fcd1dddbb2d21513b4456)
*
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/balancer/TestBalancerWithNodeGroup.java
*
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/balancer/TestBalancer.java
* hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
*
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/balancer/TestBalancerWithHANameNodes.java
*
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/balancer/Balancer.java
*
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/balancer/BalancerParameters.java
*
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/balancer/TestBalancerWithMultipleNameNodes.java
> Balancer#Parameters class could use a builder pattern
> -----------------------------------------------------
>
> Key: HDFS-9008
> URL: https://issues.apache.org/jira/browse/HDFS-9008
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: balancer & mover
> Reporter: Chris Trezzo
> Assignee: Chris Trezzo
> Priority: Minor
> Fix For: 2.8.0
>
> Attachments: HDFS-9008-trunk-v1.patch, HDFS-9008-trunk-v2.patch,
> HDFS-9008-trunk-v3.patch, HDFS-9008-trunk-v4.patch, HDFS-9008-trunk-v5.patch
>
>
> The Balancer#Parameters class is violating a few checkstyle rules.
> # Instance variables are not privately scoped and do not have accessor
> methods.
> # The Balancer#Parameter constructor has too many arguments (according to
> checkstyle).
> Changing this class to use the builder pattern could fix both of these style
> issues.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
