[ https://issues.apache.org/jira/browse/HDFS-9111?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mingliang Liu updated HDFS-9111: -------------------------------- Attachment: HDFS-9111.001.patch Thank you [~wheat9] for the useful comments. I'm very glad that the Hadoop committers are so responsive to new patches. The v1 patch fixes the two small problems. I'm also working on [HDFS-8733] to move server related definition in {{hdfs.proto}} to server side. After that, all client side data structures, protobuf definitions and convert utilities will be in {{hadoop-hdfs-client}} module; server side code in {{hadoop-hdfs}} module. > Move hdfs-client protobuf convert methods from PBHelper to PBHelperClient > ------------------------------------------------------------------------- > > Key: HDFS-9111 > URL: https://issues.apache.org/jira/browse/HDFS-9111 > Project: Hadoop HDFS > Issue Type: Sub-task > Reporter: Mingliang Liu > Assignee: Mingliang Liu > Attachments: HDFS-9111.000.patch, HDFS-9111.001.patch > > > *TL;DR* This jira tracks the effort of moving PB helper methods, which > convert client side data structure to and from protobuf, to the > {{hadoop-hdfs-client}} module. > Currently the {{PBHelper}} class contains helper methods converting both > client and server side data structures from/to protobuf. As we move client > (and common) classes to {{hadoop-hdfs-client}} module (see [HDFS-8053] and > [HDFS-9039]), we also need to move client module related PB converters to > client module. > A good place may be a new class named {{PBHelperClient}}. After this, the > existing {{PBHelper}} class stays in {{hadoop-hdfs}} module with converters > for converting server side data structures. -- This message was sent by Atlassian JIRA (v6.3.4#6332)