[ https://issues.apache.org/jira/browse/HDFS-8733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14902176#comment-14902176 ]
Hadoop QA commented on HDFS-8733: --------------------------------- \\ \\ | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:red}-1{color} | pre-patch | 18m 11s | Findbugs (version ) appears to be broken on trunk. | | {color:green}+1{color} | @author | 0m 0s | The patch does not contain any @author tags. | | {color:green}+1{color} | tests included | 0m 0s | The patch appears to include 1 new or modified test files. | | {color:green}+1{color} | javac | 7m 59s | There were no new javac warning messages. | | {color:green}+1{color} | javadoc | 10m 10s | There were no new javadoc warning messages. | | {color:green}+1{color} | release audit | 0m 24s | The applied patch does not increase the total number of release audit warnings. | | {color:green}+1{color} | checkstyle | 2m 20s | There were no new checkstyle issues. | | {color:green}+1{color} | whitespace | 0m 0s | The patch has no lines that end in whitespace. | | {color:green}+1{color} | install | 1m 36s | mvn install still works. | | {color:green}+1{color} | eclipse:eclipse | 0m 33s | The patch built with eclipse:eclipse. | | {color:green}+1{color} | findbugs | 5m 13s | The patch does not introduce any new Findbugs (version 3.0.0) warnings. | | {color:green}+1{color} | native | 3m 12s | Pre-build of native portion | | {color:red}-1{color} | hdfs tests | 169m 30s | Tests failed in hadoop-hdfs. | | {color:green}+1{color} | hdfs tests | 0m 29s | Tests passed in hadoop-hdfs-client. | | {color:red}-1{color} | hdfs tests | 0m 13s | Tests failed in bkjournal. | | | | 219m 54s | | \\ \\ || Reason || Tests || | Failed unit tests | hadoop.hdfs.TestFileAppend4 | | | hadoop.hdfs.TestRead | | | hadoop.hdfs.TestHdfsAdmin | | | hadoop.hdfs.TestClientReportBadBlock | | | hadoop.hdfs.TestAppendSnapshotTruncate | | | hadoop.hdfs.TestFileAppendRestart | | | hadoop.TestRefreshCallQueue | | | hadoop.hdfs.TestListFilesInDFS | | | hadoop.security.TestPermissionSymlinks | | | hadoop.hdfs.TestDFSRollback | | | hadoop.hdfs.TestFileConcurrentReader | | | hadoop.hdfs.TestFileAppend2 | | | hadoop.hdfs.TestGetFileChecksum | | | hadoop.hdfs.crypto.TestHdfsCryptoStreams | | | hadoop.hdfs.TestBlockStoragePolicy | | | hadoop.hdfs.TestCrcCorruption | | | hadoop.hdfs.TestDFSUpgrade | | | hadoop.hdfs.TestLeaseRecovery2 | | | hadoop.cli.TestXAttrCLI | | | hadoop.hdfs.TestDFSShell | | | hadoop.hdfs.protocol.datatransfer.sasl.TestSaslDataTransfer | | | hadoop.security.TestPermission | | | hadoop.hdfs.TestFileCreationDelete | | | hadoop.hdfs.TestDFSStorageStateRecovery | | | hadoop.hdfs.TestAppendDifferentChecksum | | | hadoop.hdfs.TestRemoteBlockReader | | | hadoop.hdfs.TestRestartDFS | | | hadoop.cli.TestHDFSCLI | | | hadoop.hdfs.TestHDFSFileSystemContract | | | hadoop.cli.TestAclCLI | | | hadoop.hdfs.TestDFSPermission | | | hadoop.cli.TestDeleteCLI | | | hadoop.cli.TestCryptoAdminCLI | | | hadoop.hdfs.TestDFSStartupVersions | | | hadoop.hdfs.TestWriteBlockGetsBlockLengthHint | | | hadoop.hdfs.TestAbandonBlock | | | hadoop.hdfs.TestFetchImage | | | hadoop.hdfs.TestDatanodeDeath | | | hadoop.hdfs.TestDFSClientExcludedNodes | | | hadoop.hdfs.TestSnapshotCommands | | | hadoop.hdfs.TestDFSOutputStream | | | hadoop.hdfs.TestDFSInotifyEventInputStream | | | hadoop.hdfs.TestReservedRawPaths | | Timed out tests | org.apache.hadoop.hdfs.server.datanode.TestDataNodeMetrics | | Failed build | bkjournal | \\ \\ || Subsystem || Report/Notes || | Patch URL | http://issues.apache.org/jira/secure/attachment/12761555/HFDS-8733.000.patch | | Optional Tests | javac unit javadoc findbugs checkstyle | | git revision | trunk / dfd807a | | hadoop-hdfs test log | https://builds.apache.org/job/PreCommit-HDFS-Build/12581/artifact/patchprocess/testrun_hadoop-hdfs.txt | | hadoop-hdfs-client test log | https://builds.apache.org/job/PreCommit-HDFS-Build/12581/artifact/patchprocess/testrun_hadoop-hdfs-client.txt | | bkjournal test log | https://builds.apache.org/job/PreCommit-HDFS-Build/12581/artifact/patchprocess/testrun_bkjournal.txt | | Test Results | https://builds.apache.org/job/PreCommit-HDFS-Build/12581/testReport/ | | Java | 1.7.0_55 | | uname | Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux | | Console output | https://builds.apache.org/job/PreCommit-HDFS-Build/12581/console | This message was automatically generated. > Keep server related definition in hdfs.proto on server side > ----------------------------------------------------------- > > Key: HDFS-8733 > URL: https://issues.apache.org/jira/browse/HDFS-8733 > Project: Hadoop HDFS > Issue Type: Sub-task > Reporter: Yi Liu > Assignee: Mingliang Liu > Attachments: HFDS-8733.000.patch > > > In [HDFS-8726], we moved the protobuf files that define the client-sever > protocols to {{hadoop-hdfs-client}} module. In {{hdfs.proto}} , there are > some server related definition. This jira tracks the effort of moving those > server related definition back to {{hadoop-hdfs}} module. A good place may be > a new file named {{HdfsServer.proto}}. -- This message was sent by Atlassian JIRA (v6.3.4#6332)