[ https://issues.apache.org/jira/browse/HDFS-1562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12978666#action_12978666 ]
Hadoop QA commented on HDFS-1562: --------------------------------- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12467146/hdfs-1562-1.patch against trunk revision 1056206. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 17 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these core unit tests: -1 contrib tests. The patch failed contrib unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://hudson.apache.org/hudson/job/PreCommit-HDFS-Build/88//testReport/ Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-HDFS-Build/88//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://hudson.apache.org/hudson/job/PreCommit-HDFS-Build/88//console This message is automatically generated. > Add rack policy tests > --------------------- > > Key: HDFS-1562 > URL: https://issues.apache.org/jira/browse/HDFS-1562 > Project: Hadoop HDFS > Issue Type: Test > Components: name-node, test > Affects Versions: 0.23.0 > Reporter: Eli Collins > Assignee: Eli Collins > Attachments: hdfs-1562-1.patch > > > The existing replication tests (TestBlocksWithNotEnoughRacks, > TestPendingReplication, TestOverReplicatedBlocks, TestReplicationPolicy, > TestUnderReplicatedBlocks, and TestReplication) are missing tests for rack > policy violations. This jira adds the following tests which I created when > generating a new patch for HDFS-15. > * Test that blocks that have a sufficient number of total replicas, but are > not replicated cross rack, get replicated cross rack when a rack becomes > available. > * Test that new blocks for an underreplicated file will get replicated cross > rack. > * Mark a block as corrupt, test that when it is re-replicated that it is > still replicated across racks. > * Reduce the replication factor of a file, making sure that the only block > that is across racks is not removed when deleting replicas. > * Test that when a block is replicated because a replica is lost due to host > failure the the rack policy is preserved. > * Test that when the execss replicas of a block are reduced due to a node > re-joining the cluster the rack policy is not violated. > * Test that rack policy is still respected when blocks are replicated due to > node decommissioning. > * Test that rack policy is still respected when blocks are replicated due to > node decommissioning, even when the blocks are over-replicated. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.