[
https://issues.apache.org/jira/browse/HDFS-1572?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jakob Homan updated HDFS-1572:
------------------------------
Attachment: HDFS-1572.patch
The code is definitely wrong, but I think the entire method can be refactored
to be more readable and clear. Right now it's a bit of a mess. I've attached
a patch which I think does this. Liyin, what do you think?
> Checkpointer should trigger checkpoint with specified period.
> -------------------------------------------------------------
>
> Key: HDFS-1572
> URL: https://issues.apache.org/jira/browse/HDFS-1572
> Project: Hadoop HDFS
> Issue Type: Bug
> Reporter: Liyin Liang
> Priority: Blocker
> Attachments: 1527-1.diff, HDFS-1572.patch
>
>
> {code:}
> long now = now();
> boolean shouldCheckpoint = false;
> if(now >= lastCheckpointTime + periodMSec) {
> shouldCheckpoint = true;
> } else {
> long size = getJournalSize();
> if(size >= checkpointSize)
> shouldCheckpoint = true;
> }
> {code}
> {dfs.namenode.checkpoint.period} in configuration determines the period of
> checkpoint. However, with above code, the Checkpointer triggers a checkpoint
> every 5 minutes (periodMSec=5*60*1000). According to SecondaryNameNode.java,
> the first *if* statement should be:
> {code:}
> if(now >= lastCheckpointTime + 1000 * checkpointPeriod) {
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
