[
https://issues.apache.org/jira/browse/HDFS-9141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14935228#comment-14935228
]
Yi Liu commented on HDFS-9141:
------------------------------
The test failures are unrelated, and checkstyle is about the file contains too
much lines, and we don't need to fix it.
Will commit the patch shortly.
> Thread leak in Datanode#refreshVolumes
> --------------------------------------
>
> Key: HDFS-9141
> URL: https://issues.apache.org/jira/browse/HDFS-9141
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: datanode
> Affects Versions: 3.0.0, 2.7.1
> Reporter: Uma Maheswara Rao G
> Assignee: Uma Maheswara Rao G
> Attachments: HDFS-9141.00.patch
>
>
> In refreshVolumes, we are creating executor service and submitting volume
> addition tasks to it.
> But we are not shutting down the service after the use. Even though we are
> not holding instance level service, the initialized thread could be left out.
> {code}
> ExecutorService service = Executors.newFixedThreadPool(
> changedVolumes.newLocations.size());
> {code}
> So, simple fix for this would be to shutdown the service after its use.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
