[ https://issues.apache.org/jira/browse/HDFS-7533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14936360#comment-14936360 ]
Yongjun Zhang commented on HDFS-7533: ------------------------------------- Hi [~kihwal] and [~eepayne], Thanks for your earlier work here. It seems helpful to add a WARN message with e's info when Throwable is caught below. Would you please comment? Thanks much. {code} + try { + xserver.sendOOBToPeers(); + ((DataXceiverServer) this.dataXceiverServer.getRunnable()).kill(); + this.dataXceiverServer.interrupt(); + } catch (Throwable e) { + // Ignore, since the out of band messaging is advisory. + } {code} > Datanode sometimes does not shutdown on receiving upgrade shutdown command > -------------------------------------------------------------------------- > > Key: HDFS-7533 > URL: https://issues.apache.org/jira/browse/HDFS-7533 > Project: Hadoop HDFS > Issue Type: Bug > Reporter: Kihwal Lee > Assignee: Eric Payne > Labels: 2.6.1-candidate > Fix For: 2.7.0, 2.6.1 > > Attachments: HDFS-7533-branch-2.6-v1.patch, HDFS-7533.v1.txt > > > When datanode is told to shutdown via the dfsadmin command during rolling > upgrade, it may not shutdown. This is because not all writers have responder > running, but sendOOB() tries anyway. This causes NPE and the shutdown thread > dies, halting the shutdown after only shutting down DataXceiverServer. -- This message was sent by Atlassian JIRA (v6.3.4#6332)