[ https://issues.apache.org/jira/browse/HDFS-884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12981060#action_12981060 ]
Konstantin Shvachko commented on HDFS-884: ------------------------------------------ N> Shouldn't there be a fail() call after the dn assignment line? See the next line {code}assertNull("Data-node startup should have failed.", dn);{code} This will fail the test if the DN starts. > DataNode makeInstance should report the directory list when failing to start > up > ------------------------------------------------------------------------------- > > Key: HDFS-884 > URL: https://issues.apache.org/jira/browse/HDFS-884 > Project: Hadoop HDFS > Issue Type: Improvement > Components: data-node > Affects Versions: 0.22.0 > Reporter: Steve Loughran > Assignee: Steve Loughran > Priority: Minor > Fix For: 0.22.0 > > Attachments: HDFS-884.patch, HDFS-884.patch, InvalidDirs.patch, > InvalidDirs.patch > > > When {{Datanode.makeInstance()}} cannot work with one of the directories in > dfs.data.dir, it logs this at warn level (while losing the stack trace). > It should include the nested exception for better troubleshooting. Then, when > all dirs in the list fail, an exception is thrown, but this exception does > not include the list of directories. It should list the absolute path of > every missing/failing directory, so that whoever sees the exception can see > where to start looking for problems: either the filesystem or the > configuration. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.