[ https://issues.apache.org/jira/browse/HDFS-8979?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mingliang Liu updated HDFS-8979: -------------------------------- Attachment: HDFS-8979.000.patch The v0 patch addresses the following warnings in the {{hadoop-hdfs-client}} module. The fixes were mostly done automatically via Intellij IDE or shell script. The changes are mainly as follows: # Replace try-catch-finally with try with resource management block # Format the lines exceeding 80 columns # Simply if/foreach/return statement # Remove unused imports # Remove redundant exception thrown in the method header if a more general one is listed # Fixes wrong indents # Remove unused parameters in private methods (public/deprecated methods considered stable) # Language simplification like type inference for generic instance creation, using string concatenation instead of string builder for simple string construction # Trailing whitespace Some warnings can be fixed separately as they are case-by-case dependent, complex for automatic fix, or error-prone. Including but not limited to: * Methods that are public but never be used in {{hadoop-hdfs-client}} * Potential false report as _value never used after assigned_, _assert has side effects_ * Method parameter that can be removed as the passed value is always constant * Non-java (e.g. XML) problems * Overrides deprecated methods > Clean up checkstyle warnings in hadoop-hdfs-client module > --------------------------------------------------------- > > Key: HDFS-8979 > URL: https://issues.apache.org/jira/browse/HDFS-8979 > Project: Hadoop HDFS > Issue Type: Task > Reporter: Mingliang Liu > Assignee: Mingliang Liu > Attachments: HDFS-8979.000.patch > > > This jira tracks the effort of cleaning up checkstyle warnings in > {{hadoop-hdfs-client}} module. -- This message was sent by Atlassian JIRA (v6.3.4#6332)