[ 
https://issues.apache.org/jira/browse/HDFS-8164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14940536#comment-14940536
 ] 

Yongjun Zhang commented on HDFS-8164:
-------------------------------------

Hi [~xiaochen],

Thanks for working on this issue. The patch looks good, one comment here:
{code}
cluster.getNamesystem().getFSImage().getStorage().getCTime()
{code}
is a quite deep call. I'd suggest that we can create an API at different level, 
such as
{{
FSNamesystem.getCTime()
FSImage.getCTime()
}}

Hi [~cnauroth], thanks for creating this jira. Would you cmment whether my 
suggestion above makes sense to you?

Thanks a lot.




> cTime is 0 in VERSION file for newly formatted NameNode.
> --------------------------------------------------------
>
>                 Key: HDFS-8164
>                 URL: https://issues.apache.org/jira/browse/HDFS-8164
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: namenode
>    Affects Versions: 2.0.3-alpha
>            Reporter: Chris Nauroth
>            Assignee: Xiao Chen
>            Priority: Minor
>         Attachments: HDFS-8164.001.patch, HDFS-8164.002.patch
>
>
> After formatting a NameNode and inspecting its VERSION file, the cTime 
> property shows 0.  The value does get updated to current time during an 
> upgrade, but I believe this is intended to be the creation time of the 
> cluster, and therefore the initial value of 0 before an upgrade can cause 
> confusion.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to