[ 
https://issues.apache.org/jira/browse/HDFS-9187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14940616#comment-14940616
 ] 

Colin Patrick McCabe commented on HDFS-9187:
--------------------------------------------

bq. Globber is only place that uses the FS tracer?

Yeah

bq. This patch seems good to me. We should work on the Masatake Iwasaki idea in 
the meantime "for everyone else.." to save having to do null checks.

Agree.  I filed HTRACE-275 for this.

> Check if tracer is null before using it
> ---------------------------------------
>
>                 Key: HDFS-9187
>                 URL: https://issues.apache.org/jira/browse/HDFS-9187
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: tracing
>    Affects Versions: 2.8.0
>            Reporter: stack
>            Assignee: Colin Patrick McCabe
>         Attachments: HDFS-9187.001.patch, HDFS-9187.002.patch
>
>
> Saw this where an hbase that has not been updated to htrace-4.0.1 was trying 
> to start:
> {code}
> Oct 1, 5:12:11.861 AM FATAL org.apache.hadoop.hbase.master.HMaster
> Failed to become active master
> java.lang.NullPointerException
> at org.apache.hadoop.fs.Globber.glob(Globber.java:145)
> at org.apache.hadoop.fs.FileSystem.globStatus(FileSystem.java:1634)
> at org.apache.hadoop.hbase.util.FSUtils.getTableDirs(FSUtils.java:1372)
> at 
> org.apache.hadoop.hbase.util.FSTableDescriptors.getAll(FSTableDescriptors.java:206)
> at 
> org.apache.hadoop.hbase.master.HMaster.finishActiveMasterInitialization(HMaster.java:619)
> at org.apache.hadoop.hbase.master.HMaster.access$500(HMaster.java:169)
> at org.apache.hadoop.hbase.master.HMaster$1.run(HMaster.java:1481)
> at java.lang.Thread.run(Thread.java:745)
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to