[ https://issues.apache.org/jira/browse/HDFS-9176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14945448#comment-14945448 ]
Lei (Eddy) Xu commented on HDFS-9176: ------------------------------------- [~templedf] thanks a lot for the patch. One question: {code} // If the scan didn't complete before the shutdown was run, check // that the shutdown was timely if (finalMs > 0) { LOG.info("Scanner took " + (Time.monotonicNow() - finalMs) + "ms to shutdown"); assertTrue("Scanner took too long to shutdown", Time.monotonicNow() - finalMs < 1000L); } {code} Because {{masterThread}} and {{reportCompileThreadPool}} will be terminated within 1 minutes, should we wait and retries several times here so that the above code has higher chance to be executed? > TestDirectoryScanner#testThrottling often fails. > ------------------------------------------------ > > Key: HDFS-9176 > URL: https://issues.apache.org/jira/browse/HDFS-9176 > Project: Hadoop HDFS > Issue Type: Bug > Components: test > Affects Versions: 2.8.0 > Reporter: Yi Liu > Assignee: Daniel Templeton > Priority: Minor > Attachments: HDFS-9176.001.patch > > > https://builds.apache.org/job/PreCommit-HDFS-Build/12736/testReport/ > https://builds.apache.org/job/PreCommit-HADOOP-Build/7732/testReport/ -- This message was sent by Atlassian JIRA (v6.3.4#6332)