[ 
https://issues.apache.org/jira/browse/HDFS-9129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14947444#comment-14947444
 ] 

Daryn Sharp commented on HDFS-9129:
-----------------------------------

Very close to a prototype I was working on.  To save some reviewing time, can 
you detail which chunks of code are not wholesale copy-paste into the block 
manager?  For those altered chunks, what logic was changed?  There's been a 
number of dicey safemode block count bugs, some elusive ones still exist, so an 
initial change should defer any logic changes to another jira to minimize risk.

> Move the safemode block count into BlockManager
> -----------------------------------------------
>
>                 Key: HDFS-9129
>                 URL: https://issues.apache.org/jira/browse/HDFS-9129
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>            Reporter: Haohui Mai
>            Assignee: Mingliang Liu
>         Attachments: HDFS-9129.000.patch, HDFS-9129.001.patch
>
>
> The {{SafeMode}} needs to track whether there are enough blocks so that the 
> NN can get out of the safemode. These fields can moved to the 
> {{BlockManager}} class.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to