[ https://issues.apache.org/jira/browse/HDFS-9110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14951342#comment-14951342 ]
Hudson commented on HDFS-9110: ------------------------------ FAILURE: Integrated in Hadoop-Mapreduce-trunk #2450 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2450/]) HDFS-9110. Use Files.walkFileTree in NNUpgradeUtil#doPreUpgrade for (wang: rev 357b1fd0822447f9e73a20c69f37006d9a37ecbc) * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NNUpgradeUtil.java * hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt > Use Files.walkFileTree in NNUpgradeUtil#doPreUpgrade for better efficiency > -------------------------------------------------------------------------- > > Key: HDFS-9110 > URL: https://issues.apache.org/jira/browse/HDFS-9110 > Project: Hadoop HDFS > Issue Type: Improvement > Affects Versions: 2.7.0 > Reporter: Charlie Helin > Assignee: Charlie Helin > Priority: Minor > Fix For: 2.8.0 > > Attachments: HDFS-9110.00.patch, HDFS-9110.01.patch, > HDFS-9110.02.patch, HDFS-9110.03.patch, HDFS-9110.04.patch, > HDFS-9110.05.patch, HDFS-9110.06.patch, HDFS-9110.07.patch, HDFS-9110.08.patch > > > This is a request to do some cosmetic improvements on top of HDFS-8480. There > a couple of File -> java.nio.file.Path conversions which is a little bit > distracting. > The second aspect is more around efficiency, to be perfectly honest I'm not > sure what the number of files that may be processed. However as HDFS-8480 > eludes to it appears that this number could be significantly large. > The current implementation is basically a collect and process where all files > first is being examined; put into a collection and after that processed. > HDFS-8480 could simply be further enhanced by employing a single iteration > without creating an intermediary collection of filenames by using a FileWalker -- This message was sent by Atlassian JIRA (v6.3.4#6332)