[ https://issues.apache.org/jira/browse/HDFS-9184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14951646#comment-14951646 ]
Hadoop QA commented on HDFS-9184: --------------------------------- \\ \\ | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | pre-patch | 26m 16s | Pre-patch trunk compilation is healthy. | | {color:green}+1{color} | @author | 0m 0s | The patch does not contain any @author tags. | | {color:green}+1{color} | tests included | 0m 0s | The patch appears to include 2 new or modified test files. | | {color:green}+1{color} | javac | 12m 17s | There were no new javac warning messages. | | {color:green}+1{color} | javadoc | 12m 56s | There were no new javadoc warning messages. | | {color:red}-1{color} | release audit | 0m 23s | The applied patch generated 1 release audit warnings. | | {color:red}-1{color} | checkstyle | 2m 39s | The applied patch generated 9 new checkstyle issues (total was 229, now 237). | | {color:green}+1{color} | whitespace | 0m 1s | The patch has no lines that end in whitespace. | | {color:green}+1{color} | install | 2m 3s | mvn install still works. | | {color:green}+1{color} | eclipse:eclipse | 0m 45s | The patch built with eclipse:eclipse. | | {color:red}-1{color} | findbugs | 6m 33s | The patch appears to introduce 2 new Findbugs (version 3.0.0) warnings. | | {color:red}-1{color} | common tests | 10m 28s | Tests failed in hadoop-common. | | {color:red}-1{color} | hdfs tests | 149m 16s | Tests failed in hadoop-hdfs. | | | | 224m 4s | | \\ \\ || Reason || Tests || | FindBugs | module:hadoop-hdfs | | Failed unit tests | hadoop.fs.shell.find.TestName | | | hadoop.fs.shell.find.TestIname | | | hadoop.fs.TestLocalFsFCStatistics | | | hadoop.fs.shell.find.TestFind | | | hadoop.ipc.TestIPC | | | hadoop.ha.TestZKFailoverController | | | hadoop.security.ssl.TestReloadingX509TrustManager | | | hadoop.test.TestTimedOutTestsListener | | | hadoop.fs.shell.find.TestPrint | | | hadoop.hdfs.TestWriteRead | | | hadoop.hdfs.server.namenode.snapshot.TestCheckpointsWithSnapshots | | | hadoop.hdfs.server.namenode.ha.TestDNFencing | | | hadoop.hdfs.server.namenode.ha.TestStandbyIsHot | | | hadoop.hdfs.TestRollingUpgrade | | | hadoop.hdfs.TestHFlush | | | hadoop.hdfs.TestParallelRead | | | hadoop.hdfs.TestBlockReaderLocalLegacy | | | hadoop.hdfs.server.namenode.TestAuditLogger | | | hadoop.hdfs.server.namenode.TestXAttrConfigFlag | | | hadoop.hdfs.TestPread | | | hadoop.hdfs.TestDFSStripedOutputStream | | | hadoop.hdfs.TestWriteConfigurationToDFS | | | hadoop.hdfs.TestDFSRollback | | | hadoop.hdfs.TestDataTransferKeepalive | | | hadoop.hdfs.TestDFSFinalize | | | hadoop.hdfs.server.namenode.ha.TestDNFencingWithReplication | | | hadoop.hdfs.server.namenode.metrics.TestNNMetricFilesInGetListingOps | | | hadoop.hdfs.server.namenode.snapshot.TestNestedSnapshots | | | hadoop.hdfs.server.namenode.ha.TestHASafeMode | | | hadoop.hdfs.TestDFSShell | | | hadoop.hdfs.server.namenode.ha.TestDFSUpgradeWithHA | | | hadoop.hdfs.TestSeekBug | | | hadoop.hdfs.TestCrcCorruption | | | hadoop.hdfs.server.namenode.TestStorageRestore | | | hadoop.hdfs.TestAbandonBlock | | | hadoop.hdfs.TestGetFileChecksum | | | hadoop.hdfs.server.namenode.TestBlockUnderConstruction | | | hadoop.hdfs.TestSafeModeWithStripedFile | | | hadoop.hdfs.tools.offlineImageViewer.TestOfflineImageViewerForContentSummary | | | hadoop.hdfs.TestFileCreationDelete | | | hadoop.hdfs.TestReadWhileWriting | | | hadoop.hdfs.TestDFSStripedOutputStreamWithFailure010 | | | hadoop.hdfs.security.TestDelegationToken | | | hadoop.hdfs.server.namenode.ha.TestHAAppend | | | hadoop.hdfs.TestMissingBlocksAlert | | | hadoop.hdfs.TestBlocksScheduledCounter | | | hadoop.hdfs.TestSmallBlock | | | hadoop.hdfs.TestDFSClientRetries | | | hadoop.hdfs.TestDFSMkdirs | | | hadoop.hdfs.server.namenode.TestFavoredNodesEndToEnd | | | hadoop.hdfs.server.namenode.ha.TestFailureToReadEdits | | | hadoop.hdfs.server.namenode.TestNameNodeMXBean | | | hadoop.hdfs.server.namenode.TestLargeDirectoryDelete | | | hadoop.hdfs.server.namenode.TestDeleteRace | | | hadoop.hdfs.TestFSInputChecker | | | hadoop.hdfs.server.namenode.ha.TestXAttrsWithHA | | | hadoop.hdfs.server.namenode.ha.TestHAMetrics | | | hadoop.hdfs.TestRollingUpgradeRollback | | | hadoop.hdfs.TestRemoteBlockReader | | | hadoop.hdfs.TestBlockStoragePolicy | | | hadoop.hdfs.TestLeaseRecovery | | | hadoop.hdfs.server.namenode.TestBackupNode | | | hadoop.hdfs.TestBlockReaderLocal | | | hadoop.hdfs.tools.offlineImageViewer.TestOfflineImageViewerForXAttr | | | hadoop.hdfs.tools.TestDebugAdmin | | | hadoop.hdfs.TestReadStripedFileWithDecoding | | | hadoop.hdfs.TestLargeBlock | | | hadoop.hdfs.server.namenode.TestFSNamesystemMBean | | | hadoop.hdfs.tools.TestDFSZKFailoverController | | | hadoop.hdfs.TestDistributedFileSystem | | | hadoop.hdfs.TestListFilesInFileContext | | | hadoop.hdfs.server.namenode.TestNameNodeRecovery | | | hadoop.hdfs.TestFileAppend2 | | | hadoop.hdfs.TestFsShellPermission | | | hadoop.hdfs.server.namenode.ha.TestHAFsck | | | hadoop.hdfs.TestRollingUpgradeDowngrade | | | hadoop.hdfs.TestFileLengthOnClusterRestart | | | hadoop.hdfs.security.TestDelegationTokenForProxyUser | | | hadoop.hdfs.TestWriteReadStripedFile | | | hadoop.hdfs.TestParallelUnixDomainRead | | | hadoop.hdfs.server.namenode.TestQuotaWithStripedBlocks | | | hadoop.hdfs.TestGetBlocks | | | hadoop.hdfs.security.token.block.TestBlockToken | | | hadoop.hdfs.web.TestWebHdfsTokens | | | hadoop.hdfs.TestErasureCodingPolicies | | | hadoop.hdfs.TestEncryptionZonesWithKMS | | | hadoop.hdfs.TestClientReportBadBlock | | | hadoop.hdfs.TestDFSStorageStateRecovery | | | hadoop.hdfs.TestRestartDFS | | | hadoop.hdfs.TestFileAppend4 | | | hadoop.hdfs.server.namenode.ha.TestFailoverWithBlockTokensEnabled | | | hadoop.hdfs.TestSetTimes | | | hadoop.hdfs.server.namenode.TestAclConfigFlag | | | hadoop.hdfs.server.namenode.ha.TestSeveralNameNodes | | | hadoop.hdfs.server.namenode.TestNameNodeAcl | | | hadoop.hdfs.TestSetrepIncreasing | | | hadoop.hdfs.TestLease | | | hadoop.hdfs.TestSafeMode | | | hadoop.hdfs.server.namenode.TestEditLogAutoroll | | | hadoop.hdfs.TestDFSUpgrade | | | hadoop.hdfs.TestDecommission | | | hadoop.hdfs.TestFileStatusWithECPolicy | | | hadoop.hdfs.protocol.datatransfer.sasl.TestSaslDataTransfer | | | hadoop.hdfs.server.namenode.ha.TestQuotasWithHA | | | hadoop.hdfs.TestFileCorruption | | | hadoop.hdfs.TestDatanodeStartupFixesLegacyStorageIDs | | | hadoop.hdfs.TestQuota | | | hadoop.hdfs.server.namenode.ha.TestHarFileSystemWithHA | | | hadoop.hdfs.TestFileStatus | | | hadoop.hdfs.TestEncryptionZonesWithHA | | | hadoop.hdfs.TestDFSStripedOutputStreamWithFailure000 | | | hadoop.hdfs.server.namenode.TestProcessCorruptBlocks | | | hadoop.hdfs.TestClose | | | hadoop.hdfs.TestMultiThreadedHflush | | | hadoop.hdfs.TestDFSClientExcludedNodes | | | hadoop.hdfs.server.namenode.TestAddOverReplicatedStripedBlocks | | | hadoop.hdfs.TestFileConcurrentReader | | | hadoop.hdfs.server.namenode.snapshot.TestUpdatePipelineWithSnapshots | | | hadoop.hdfs.TestDataTransferProtocol | | | hadoop.hdfs.TestBlockReaderFactory | | | hadoop.hdfs.server.namenode.TestParallelImageWrite | | | hadoop.hdfs.server.namenode.TestCheckpoint | | | hadoop.hdfs.server.namenode.web.resources.TestWebHdfsDataLocality | | | hadoop.hdfs.TestDatanodeDeath | | | hadoop.hdfs.TestPipelines | | | hadoop.hdfs.web.TestWebHDFSAcl | | | hadoop.hdfs.tools.offlineImageViewer.TestOfflineImageViewerWithStripedBlocks | | | hadoop.hdfs.server.namenode.TestFSImage | | | hadoop.hdfs.web.TestWebHdfsWithMultipleNameNodes | | | hadoop.hdfs.server.namenode.ha.TestBootstrapStandbyWithQJM | | | hadoop.hdfs.server.namenode.TestFsckWithMultipleNameNodes | | | hadoop.hdfs.server.namenode.ha.TestFailureOfSharedDir | | | hadoop.hdfs.TestRenameWhileOpen | | | hadoop.hdfs.server.namenode.TestNameNodeXAttr | | | hadoop.hdfs.server.namenode.TestEditLogJournalFailures | | | hadoop.hdfs.server.namenode.ha.TestPendingCorruptDnMessages | | | hadoop.hdfs.TestWriteBlockGetsBlockLengthHint | | | hadoop.hdfs.server.namenode.TestFSEditLogLoader | | | hadoop.hdfs.tools.TestStoragePolicyCommands | | | hadoop.hdfs.server.namenode.TestNamenodeRetryCache | | | hadoop.hdfs.server.namenode.TestDecommissioningStatus | | | hadoop.hdfs.TestDFSStartupVersions | | | hadoop.hdfs.tools.offlineImageViewer.TestOfflineImageViewerForAcl | | | hadoop.hdfs.server.namenode.ha.TestHAStateTransitions | | | hadoop.hdfs.TestAppendSnapshotTruncate | | | hadoop.hdfs.server.namenode.TestDiskspaceQuotaUpdate | | | hadoop.hdfs.TestParallelShortCircuitReadUnCached | | | hadoop.hdfs.TestDFSClientFailover | | | hadoop.hdfs.TestFSOutputSummer | | | hadoop.hdfs.server.namenode.TestHDFSConcat | | | hadoop.hdfs.server.namenode.ha.TestInitializeSharedEdits | | | hadoop.hdfs.server.namenode.TestFSImageWithAcl | | | hadoop.hdfs.server.namenode.snapshot.TestINodeFileUnderConstructionWithSnapshot | | | hadoop.hdfs.web.TestFSMainOperationsWebHdfs | | | hadoop.hdfs.TestDFSInotifyEventInputStream | | | hadoop.hdfs.server.namenode.ha.TestRetryCacheWithHA | | | hadoop.hdfs.server.namenode.ha.TestStandbyBlockManagement | | | hadoop.hdfs.server.namenode.TestSaveNamespace | | | hadoop.hdfs.server.namenode.metrics.TestNameNodeMetrics | | | hadoop.hdfs.TestDFSPermission | | | hadoop.hdfs.server.namenode.snapshot.TestSnapshotStatsMXBean | | | hadoop.hdfs.TestListFilesInDFS | | | hadoop.hdfs.TestModTime | | | hadoop.hdfs.TestReservedRawPaths | | | hadoop.hdfs.TestHDFSFileSystemContract | | | hadoop.hdfs.server.namenode.TestHostsFiles | | | hadoop.hdfs.TestFileCreation | | | hadoop.hdfs.server.namenode.TestINodeAttributeProvider | | | hadoop.hdfs.TestParallelShortCircuitRead | | | hadoop.hdfs.server.namenode.TestFSImageWithXAttr | | | hadoop.hdfs.TestParallelShortCircuitLegacyRead | | | hadoop.hdfs.server.namenode.TestFileJournalManager | | | hadoop.hdfs.TestFileCreationEmpty | | | hadoop.hdfs.TestRead | | | hadoop.hdfs.server.namenode.TestAuditLogAtDebug | | | hadoop.hdfs.TestFileAppend | | | hadoop.hdfs.web.TestWebHdfsFileSystemContract | | | hadoop.hdfs.server.namenode.TestSecureNameNode | | | hadoop.hdfs.web.TestWebHDFS | | | hadoop.hdfs.tools.offlineEditsViewer.TestOfflineEditsViewer | | | hadoop.hdfs.TestReplaceDatanodeOnFailure | | | hadoop.hdfs.server.namenode.TestAddBlock | | | hadoop.hdfs.server.namenode.ha.TestPipelinesFailover | | | hadoop.hdfs.TestFetchImage | | | hadoop.hdfs.TestInjectionForSimulatedStorage | | | hadoop.hdfs.TestFileCreationClient | | | hadoop.hdfs.server.namenode.TestAddStripedBlocks | | | hadoop.hdfs.server.namenode.TestNameEditsConfigs | | | hadoop.hdfs.server.namenode.TestCacheDirectives | | | hadoop.hdfs.TestClientProtocolForPipelineRecovery | | | hadoop.hdfs.TestDFSRemove | | | hadoop.hdfs.TestFileAppendRestart | | | hadoop.hdfs.TestDFSOutputStream | | | hadoop.hdfs.TestDisableConnCache | | | hadoop.hdfs.TestParallelShortCircuitReadNoChecksum | | | hadoop.hdfs.server.namenode.ha.TestStandbyCheckpoints | | | hadoop.hdfs.tools.offlineImageViewer.TestOfflineImageViewer | | | hadoop.hdfs.server.namenode.snapshot.TestFileContextSnapshot | | | hadoop.hdfs.server.namenode.TestStartup | | | hadoop.hdfs.server.namenode.snapshot.TestSetQuotaWithSnapshot | | | hadoop.hdfs.TestBlockMissingException | | | hadoop.hdfs.server.namenode.TestProtectedDirectories | | Timed out tests | org.apache.hadoop.hdfs.server.namenode.snapshot.TestRenameWithSnapshots | | | org.apache.hadoop.hdfs.web.TestWebHDFSForHA | \\ \\ || Subsystem || Report/Notes || | Patch URL | http://issues.apache.org/jira/secure/attachment/12765950/HDFS-9184.002.patch | | Optional Tests | javadoc javac unit findbugs checkstyle | | git revision | trunk / def374e | | Release Audit | https://builds.apache.org/job/PreCommit-HDFS-Build/12910/artifact/patchprocess/patchReleaseAuditProblems.txt | | checkstyle | https://builds.apache.org/job/PreCommit-HDFS-Build/12910/artifact/patchprocess/diffcheckstylehadoop-common.txt | | Findbugs warnings | https://builds.apache.org/job/PreCommit-HDFS-Build/12910/artifact/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html | | hadoop-common test log | https://builds.apache.org/job/PreCommit-HDFS-Build/12910/artifact/patchprocess/testrun_hadoop-common.txt | | hadoop-hdfs test log | https://builds.apache.org/job/PreCommit-HDFS-Build/12910/artifact/patchprocess/testrun_hadoop-hdfs.txt | | Test Results | https://builds.apache.org/job/PreCommit-HDFS-Build/12910/testReport/ | | Java | 1.7.0_55 | | uname | Linux asf907.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux | | Console output | https://builds.apache.org/job/PreCommit-HDFS-Build/12910/console | This message was automatically generated. > Logging HDFS operation's caller context into audit logs > ------------------------------------------------------- > > Key: HDFS-9184 > URL: https://issues.apache.org/jira/browse/HDFS-9184 > Project: Hadoop HDFS > Issue Type: Task > Reporter: Mingliang Liu > Assignee: Mingliang Liu > Attachments: HDFS-9184.000.patch, HDFS-9184.001.patch, > HDFS-9184.002.patch > > > For a given HDFS operation (e.g. delete file), it's very helpful to track > which upper level job issues it. The upper level callers may be specific > Oozie tasks, MR jobs, and hive queries. One scenario is that the namenode > (NN) is abused/spammed, the operator may want to know immediately which MR > job should be blamed so that she can kill it. To this end, the caller context > contains at least the application-dependent "tracking id". > There are several existing techniques that may be related to this problem. > 1. Currently the HDFS audit log tracks the users of the the operation which > is obviously not enough. It's common that the same user issues multiple jobs > at the same time. Even for a single top level task, tracking back to a > specific caller in a chain of operations of the whole workflow (e.g.Oozie -> > Hive -> Yarn) is hard, if not impossible. > 2. HDFS integrated {{htrace}} support for providing tracing information > across multiple layers. The span is created in many places interconnected > like a tree structure which relies on offline analysis across RPC boundary. > For this use case, {{htrace}} has to be enabled at 100% sampling rate which > introduces significant overhead. Moreover, passing additional information > (via annotations) other than span id from root of the tree to leaf is a > significant additional work. > 3. In [HDFS-4680 | https://issues.apache.org/jira/browse/HDFS-4680], there > are some related discussion on this topic. The final patch implemented the > tracking id as a part of delegation token. This protects the tracking > information from being changed or impersonated. However, kerberos > authenticated connections or insecure connections don't have tokens. > [HADOOP-8779] proposes to use tokens in all the scenarios, but that might > mean changes to several upstream projects and is a major change in their > security implementation. > We propose another approach to address this problem. We also treat HDFS audit > log as a good place for after-the-fact root cause analysis. We propose to put > the caller id (e.g. Hive query id) in threadlocals. Specially, on client side > the threadlocal object is passed to NN as a part of RPC header (optional), > while on sever side NN retrieves it from header and put it to {{Handler}}'s > threadlocals. Finally in {{FSNamesystem}}, HDFS audit logger will record the > caller context for each operation. In this way, the existing code is not > affected. > It is still challenging to keep "lying" client from abusing the caller > context. Our proposal is to add a {{signature}} field to the caller context. > The client choose to provide its signature along with the caller id. The > operator may need to validate the signature at the time of offline analysis. > The NN is not responsible for validating the signature online. -- This message was sent by Atlassian JIRA (v6.3.4#6332)