[ https://issues.apache.org/jira/browse/HDFS-9231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14956329#comment-14956329 ]
Xiao Chen commented on HDFS-9231: --------------------------------- Attached patch 001. Description below: * fsck from command line with -includeSnapshots will also show full dir of snapshots * fsck from command line without -includeSnapshots behavior unchanged * NameNode WebUI always show full dir of snapshots * Some refactoring to reuse {{getSnapshottableDirs}} and {{ListCorruptFileBlocksWithSnapshot}} * Getting all possible snapshots is not so efficient, but considering fsck should not be performed frequently and nothing is added into {{listCorruptFileBlocks}} where fslock is used, the impact should be minimal. > fsck doesn't explicitly list when Bad Replicas/Blocks are in a snapshot > ----------------------------------------------------------------------- > > Key: HDFS-9231 > URL: https://issues.apache.org/jira/browse/HDFS-9231 > Project: Hadoop HDFS > Issue Type: Bug > Components: snapshots > Reporter: Xiao Chen > Assignee: Xiao Chen > Attachments: HDFS-9231.001.patch > > > For snapshot files, fsck shows corrupt blocks with the original file dir > instead of the snapshot dir. > This can be confusing since even when the original file is deleted, a new > fsck run will still show that file as corrupted although what's actually > corrupted is the snapshot. > This is true even when given the -includeSnapshots option. -- This message was sent by Atlassian JIRA (v6.3.4#6332)