[
https://issues.apache.org/jira/browse/HDFS-1557?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ivan Kelly updated HDFS-1557:
-----------------------------
Status: Patch Available (was: Open)
According to the checklist, its Sun convention which actually says both are
good.
http://wiki.apache.org/hadoop/CodeReviewChecklist
http://www.oracle.com/technetwork/java/codeconventions-136091.html#262
>From the Sun document.
{quote}
- Align the new line with the beginning of the expression at the same level on
the previous line.
- If the above rules lead to confusing code or to code that's squished up
against the right margin, just indent 8 spaces instead.
{quote}
It seems that emacs defaults to the former, while eclipse defaults to the
latter. In the cases in which everything was squished to the right, I've
applied the eclipse form.
I've removed all the 80+ lines I introduced.
> Separate Storage from FSImage
> -----------------------------
>
> Key: HDFS-1557
> URL: https://issues.apache.org/jira/browse/HDFS-1557
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: name-node
> Affects Versions: 0.21.0
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Fix For: 0.23.0
>
> Attachments: HDFS-1557-branch-0.22.diff, HDFS-1557-branch-0.22.diff,
> HDFS-1557-trunk.diff, HDFS-1557-trunk.diff, HDFS-1557-trunk.diff,
> HDFS-1557.diff, HDFS-1557.diff, HDFS-1557.diff, HDFS-1557.diff
>
>
> FSImage currently derives from Storage and FSEditLog has to call methods
> directly on FSImage to access the filesystem. This JIRA is to separate the
> Storage class out into NNStorage so that FSEditLog is less dependent on
> FSImage. From this point, the other parts of the circular dependency should
> be easy to fix.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
