[ 
https://issues.apache.org/jira/browse/HDFS-8545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14958793#comment-14958793
 ] 

Vinayakumar B commented on HDFS-8545:
-------------------------------------

Thanks [~andreina] for the update. 
Refactor looks great.

Just one minor comment.
Can you please move new test {{TestDFSShell#testTotalDfsUsed()}} to 
{{TestDistributedFileSystem}}, as this is not shell test, this is testing of 
new API you have added.

> Refactor FS#getUsed() to use ContentSummary and add an API to fetch the total 
> file length from a specific path
> --------------------------------------------------------------------------------------------------------------
>
>                 Key: HDFS-8545
>                 URL: https://issues.apache.org/jira/browse/HDFS-8545
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>            Reporter: J.Andreina
>            Assignee: J.Andreina
>            Priority: Minor
>         Attachments: HDFS-8545.1.patch, HDFS-8545.2.patch, HDFS-8545.3.patch, 
> HDFS-8545.4.patch, HDFS-8545.5.patch
>
>
> Currently by default in FileSystem#getUsed() returns the total file size from 
> root. 
> It is good to have an api to return the total file size from specified path 
> ,same as we specify the path in "./hdfs dfs -du -s /path" .



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to