[ 
https://issues.apache.org/jira/browse/HDFS-9251?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Lei (Eddy) Xu updated HDFS-9251:
--------------------------------
    Attachment: HDFS-9251.00.patch

This patch:
* Add {{CreateFinalizedReplica}}, {{CreateRbw}}, {{CreateReplicaInPipeline}}, 
{{CreateRBW}} and {{CreateReplicaWaitingToBeRecovered}} to 
{{FsDatasetTestUtils}}.  
* Refactor {{TestFsDatasetImpl}} and {{TestWriteToReplica}} to use them.


> Refactor TestWriteToReplica and TestFsDatasetImpl to avoid explicitly 
> creating Files in tests code.
> ---------------------------------------------------------------------------------------------------
>
>                 Key: HDFS-9251
>                 URL: https://issues.apache.org/jira/browse/HDFS-9251
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: HDFS
>    Affects Versions: 2.7.1
>            Reporter: Lei (Eddy) Xu
>            Assignee: Lei (Eddy) Xu
>         Attachments: HDFS-9251.00.patch
>
>
> In {{TestWriteToReplica}} and {{TestFsDatasetImpl}}, tests directly creates 
> block and metadata files:
> {code}
> replicaInfo.getBlockFile().createNewFile();
> replicaInfo.getMetaFile().createNewFile();
> {code}
> It leaks the implementation details of {{FsDatasetImpl}}. This JIRA proposes 
> to use {{FsDatasetImplTestUtils}} (HDFS-9188) to create replicas. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to